Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-15 07:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Slight chat session controller optimization

Browse Source 
- Add should not retransmit all items
- Skip updates if they don't do anything
This commit is contained in:
Matt Bierner
2026-02-12 00:12:54 -08:00
parent 6c1af3f302
commit 4fbcb2b5de
1 changed files with 30 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/vs/workbench/api/common/extHostChatSessions.ts
View File

@@ -176,12 +176,17 @@ class ChatSessionItemImpl implements vscode.ChatSessionItem {
}
}
interface SessionCollectionListeners {
onItemsChanged(): void;
onItemChanged(item: vscode.ChatSessionItem): void;
}
class ChatSessionItemCollectionImpl implements vscode.ChatSessionItemCollection {
readonly #items = new ResourceMap<vscode.ChatSessionItem>();
#onItemsChanged: () => void;
readonly #callbacks: SessionCollectionListeners;
constructor(onItemsChanged: () => void) {
this.#onItemsChanged = onItemsChanged;
constructor(callbacks: SessionCollectionListeners) {
this.#callbacks = callbacks;
}
get size(): number {
@@ -197,7 +202,7 @@ class ChatSessionItemCollectionImpl implements vscode.ChatSessionItemCollection
for (const item of items) {
this.#items.set(item.resource, item);
}
this.#onItemsChanged();
this.#callbacks.onItemsChanged();
}
forEach(callback: (item: vscode.ChatSessionItem, collection: vscode.ChatSessionItemCollection) => unknown, thisArg?: any): void {
@@ -207,13 +212,20 @@ class ChatSessionItemCollectionImpl implements vscode.ChatSessionItemCollection
}
add(item: vscode.ChatSessionItem): void {
const existing = this.#items.get(item.resource);
if (existing && existing === item) {
// We're adding the same item again
return;
}
this.#items.set(item.resource, item);
this.#onItemsChanged();
this.#callbacks.onItemChanged(item);
}
delete(resource: vscode.Uri): void {
this.#items.delete(resource);
this.#onItemsChanged();
if (this.#items.delete(resource)) {
this.#callbacks.onItemsChanged();
}
}
get(resource: vscode.Uri): vscode.ChatSessionItem | undefined {
@@ -324,8 +336,10 @@ export class ExtHostChatSessions extends Disposable implements ExtHostChatSessio
const onDidChangeChatSessionItemStateEmitter = disposables.add(new Emitter<vscode.ChatSessionItem>());
const collection = new ChatSessionItemCollectionImpl(() => {
const collection = new ChatSessionItemCollectionImpl({
// Noop for providers
onItemsChanged: () => { },
onItemChanged: () => { }
});
// Helper to push items to main thread
@@ -400,7 +414,11 @@ export class ExtHostChatSessions extends Disposable implements ExtHostChatSessio
void this._proxy.$setChatSessionItems(controllerHandle, items);
};
const collection = new ChatSessionItemCollectionImpl(onItemsChanged);
const onItemChanged = (item: vscode.ChatSessionItem) => {
void this._proxy.$updateChatSessionItem(controllerHandle, typeConvert.ChatSessionItem.from(item));
};
const collection = new ChatSessionItemCollectionImpl({ onItemsChanged, onItemChanged });
const controller = Object.freeze<vscode.ChatSessionItemController>({
id,
@@ -420,7 +438,9 @@ export class ExtHostChatSessions extends Disposable implements ExtHostChatSessio
}
const item = new ChatSessionItemImpl(resource, label, () => {
void this._proxy.$updateChatSessionItem(controllerHandle, typeConvert.ChatSessionItem.from(item));
if (collection.get(resource) === item) {
onItemChanged(item);
}
});
return item;
},