Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-10-01 07:35:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #285661 from murataslan1/fix/terminal-view-lifecycle

Browse Source 
Fix: Replace terminal view lifecycle hack with Event.once
This commit is contained in:
Daniel Imms
2026-01-02 09:31:47 -08:00
committed by GitHub
parent 69d372b105 f786f435a8
commit 51ff08cd04
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/terminal/browser/terminalView.ts
+2 -3
View File
@@ -337,13 +337,12 @@ export class TerminalViewPane extends ViewPane {
// be focused. So wait for connection to finish, then focus.
const previousActiveElement = this.element.ownerDocument.activeElement;
if (previousActiveElement) {
// TODO: Improve lifecycle management this event should be disposed after first fire
this._register(this._terminalService.onDidChangeConnectionState(() => {
const listener = this._register(Event.once(this._terminalService.onDidChangeConnectionState)(() => {
// Only focus the terminal if the activeElement has not changed since focus() was called
// TODO: Hack
if (previousActiveElement && dom.isActiveElement(previousActiveElement)) {
this._terminalGroupService.showPanel(true);
}
this._store.delete(listener);
}));
}
}