Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 17:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

chat: position session hover above when in bottom panel (#289458)

Browse Source 
Extracts hover position logic into a dedicated getSessionHoverPosition()
method that correctly handles all viewport locations and orientations.
When the agent session view is in the bottom panel, the hover now appears
above the session rather than to the left, preventing it from hiding
session buttons.

- Adds getSessionHoverPosition() method to ChatViewPane
- Checks view location and returns appropriate HoverPosition
- Returns HoverPosition.ABOVE when panel position is BOTTOM
- Handles both sidebar and panel locations with panel position awareness

Fixes https://github.com/microsoft/vscode/issues/289369

(Commit message generated by Copilot)
This commit is contained in:
Connor Peet
2026-01-21 11:11:10 -08:00
committed by GitHub
parent c8ae698831
commit 5470529050
1 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewPane.ts
+18 -5
View File
@@ -175,10 +175,26 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
return {
position: sideSessionsOnRightPosition ? Position.RIGHT : Position.LEFT,
location: viewLocation ?? ViewContainerLocation.AuxiliaryBar
location: viewLocation ?? ViewContainerLocation.AuxiliaryBar,
};
}
private getSessionHoverPosition() {
const viewLocation = this.viewDescriptorService.getViewLocationById(this.id);
const sideBarPosition = this.layoutService.getSideBarPosition();
if (this.sessionsViewerOrientation === AgentSessionsViewerOrientation.SideBySide) {
return viewLocation === ViewContainerLocation.Sidebar && sideBarPosition === Position.RIGHT ? HoverPosition.LEFT : HoverPosition.RIGHT;
}
return {
[Position.LEFT]: HoverPosition.RIGHT,
[Position.RIGHT]: HoverPosition.LEFT,
[Position.TOP]: HoverPosition.BELOW,
[Position.BOTTOM]: HoverPosition.ABOVE
}[viewLocation === ViewContainerLocation.Panel ? this.layoutService.getPanelPosition() : sideBarPosition];
}
private updateViewPaneClasses(fromEvent: boolean): void {
const welcomeEnabled = !this.chatEntitlementService.sentiment.installed; // only show initially until Chat is setup
this.viewPaneContainer?.classList.toggle('chat-view-welcome-enabled', welcomeEnabled);
@@ -369,10 +385,7 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
source: 'chatViewPane',
filter: sessionsFilter,
overrideStyles: this.getLocationBasedColors().listOverrideStyles,
getHoverPosition: () => {
const { position } = this.getViewPositionAndLocation();
return position === Position.RIGHT ? HoverPosition.LEFT : HoverPosition.RIGHT;
},
getHoverPosition: () => this.getSessionHoverPosition(),
trackActiveEditorSession: () => {
return !this._widget || this._widget.isEmpty(); // only track and reveal if chat widget is empty
},