Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-12 11:39:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

better phrasing of extensions in prompts (#193990)

Browse Source
This commit is contained in:
Sandeep Somavarapu
2023-09-25 07:24:46 -07:00
committed by GitHub
parent 8e80e950a4
commit 5d9d2123ec
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/api/browser/mainThreadExtensionService.ts
+1 -1
View File
@@ -168,7 +168,7 @@ export class MainThreadExtensionService implements MainThreadExtensionServiceSha
if (dependencyExtension) {
this._notificationService.notify({
severity: Severity.Error,
message: localize('uninstalledDep', "Cannot activate the '{0}' extension because it depends on the '{1}' extension, which is not installed. Would you like to install the extension and reload the window?", extName, dependencyExtension.displayName),
message: localize('uninstalledDep', "Cannot activate the '{0}' extension because it depends on the extension '{1}' from '{2}', which is not installed. Would you like to install the extension and reload the window?", extName, dependencyExtension.displayName, dependencyExtension.publisherDisplayName),
actions: {
primary: [new Action('install', localize('install missing dep', "Install and Reload"), '', true,
() => this._extensionsWorkbenchService.install(dependencyExtension!)
src/vs/workbench/services/extensions/browser/extensionUrlHandler.ts
+5 -5
View File
@@ -159,7 +159,7 @@ class ExtensionUrlHandler implements IExtensionUrlHandler, IURLHandler {
await this.handleUnhandledURL(uri, { id: extensionId }, options);
return true;
} else {
extensionDisplayName = extension.displayName || extension.name;
extensionDisplayName = extension.displayName ?? '';
}
} else {
extensionDisplayName = initialHandler.extensionDisplayName;
@@ -177,11 +177,11 @@ class ExtensionUrlHandler implements IExtensionUrlHandler, IURLHandler {
}
const result = await this.dialogService.confirm({
message: localize('confirmUrl', "Allow an extension to open this URI?", extensionId),
message: localize('confirmUrl', "Allow '{0}' extension to open this URI?", extensionDisplayName),
checkbox: {
label: localize('rememberConfirmUrl', "Don't ask again for this extension."),
},
detail: `${extensionDisplayName} (${extensionId}) wants to open a URI:\n\n${uriString}`,
detail: uriString,
primaryButton: localize({ key: 'open', comment: ['&& denotes a mnemonic'] }, "&&Open")
});
@@ -267,8 +267,8 @@ class ExtensionUrlHandler implements IExtensionUrlHandler, IURLHandler {
// Install the Extension and reload the window to handle.
const result = await this.dialogService.confirm({
message: localize('installAndHandle', "Extension '{0}' is not installed. Would you like to install the extension and open this URL?", galleryExtension.displayName || galleryExtension.name),
detail: `${galleryExtension.displayName || galleryExtension.name} (${extensionIdentifier.id}) wants to open a URL:\n\n${uri.toString()}`,
message: localize('installAndHandle', "Would you like to install '{0}' extension from '{1}' to open this URI?", galleryExtension.displayName, galleryExtension.publisherDisplayName),
detail: `${localize('installDetail', "'{0}' extension wants to open a URI:", galleryExtension.displayName)}\n\n${uri.toString()}`,
primaryButton: localize({ key: 'install and open', comment: ['&& denotes a mnemonic'] }, "&&Install and Open")
});