Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-15 07:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: hygiene - replace unicode box-drawing and em-dash characters in copilotSdkHost

Browse Source
This commit is contained in:
Josh Spicer
2026-02-14 09:35:43 -08:00
parent 15c82c7b80
commit 5e744dabfe
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/vs/platform/copilotSdk/node/copilotSdkHost.ts
View File

@@ -67,12 +67,10 @@ class CopilotSdkHost extends Disposable implements ICopilotSdkService {
throw importErr;
}
// ┌──────────────────────────────────────────────────────────────┐
// │ IMPORTANT: The CLI binary MUST come from the bundled │
// │ @github/copilot-{platform}-{arch} package. Do NOT use │
// │ PATH discovery, execFileSync, or any external binary. │
// │ This must work in a signed, ASAR-packed release build. │
// └──────────────────────────────────────────────────────────────┘
// IMPORTANT: The CLI binary MUST come from the bundled
// @github/copilot-{platform}-{arch} package. Do NOT use
// PATH discovery, execFileSync, or any external binary.
// This must work in a signed, ASAR-packed release build.
let cliPath: string | undefined;
try {
const { fileURLToPath } = await import('node:url');
@@ -106,7 +104,7 @@ class CopilotSdkHost extends Disposable implements ICopilotSdkService {
}
cliEnv[key] = value;
}
// Tell the CLI to use stdio mode (no pty needed — avoids code signing issues)
// Tell the CLI to use stdio mode (no pty needed - avoids code signing issues)
cliEnv['COPILOT_AGENT_DISABLE_PTY'] = '1';
// Ensure the CLI doesn't inherit the Electron app's hardened runtime constraints
delete cliEnv['__CFBundleIdentifier'];
@@ -134,7 +132,7 @@ class CopilotSdkHost extends Disposable implements ICopilotSdkService {
// Log state transitions for debugging the "Connection is disposed" issue
process.stderr.write(`[SDK-DEBUG] Starting client with cliPath=${cliPath ?? 'default'}\n`);
try {
// Add a timeout — if start() hangs for more than 30s, something is wrong
// Add a timeout - if start() hangs for more than 30s, something is wrong
const startPromise = this._client.start();
const timeoutPromise = new Promise<never>((_, reject) =>
setTimeout(() => reject(new Error('SDK client.start() timed out after 30 seconds')), 30000)