Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-29 18:09:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #289086 from microsoft/benibenj/growing-ostrich

Browse Source 
Add telemetry for tools picker
This commit is contained in:
Benjamin Christopher Simmonds
2026-01-20 14:02:08 +01:00
committed by GitHub
parent 875711832d bb885aff94
commit 6283f18ca6
3 changed files with 39 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/chat/browser/actions/chatToolActions.ts
+1 -1
View File
@@ -188,7 +188,7 @@ class ConfigureToolsAction extends Action2 {
});
try {
const result = await instaService.invokeFunction(showToolsPicker, placeholder, description, () => entriesMap.get(), cts.token);
const result = await instaService.invokeFunction(showToolsPicker, placeholder, 'chatInput', description, () => entriesMap.get(), cts.token);
if (result) {
widget.input.selectedToolsModel.set(result, false);
}
src/vs/workbench/contrib/chat/browser/actions/chatToolPicker.ts
+37
View File
@@ -17,6 +17,7 @@ import { IContextKeyService } from '../../../../../platform/contextkey/common/co
import { ExtensionIdentifier } from '../../../../../platform/extensions/common/extensions.js';
import { ServicesAccessor } from '../../../../../platform/instantiation/common/instantiation.js';
import { IQuickInputButton, IQuickInputService, IQuickPickItem, IQuickTreeItem } from '../../../../../platform/quickinput/common/quickInput.js';
import { ITelemetryService } from '../../../../../platform/telemetry/common/telemetry.js';
import { IEditorService } from '../../../../services/editor/common/editorService.js';
import { ExtensionEditorTab, IExtensionsWorkbenchService } from '../../../extensions/common/extensions.js';
import { McpCommandIds } from '../../../mcp/common/mcpCommandIds.js';
@@ -190,6 +191,7 @@ function createToolSetTreeItem(toolset: ToolSet, checked: boolean, editorService
export async function showToolsPicker(
accessor: ServicesAccessor,
placeHolder: string,
source: string,
description?: string,
getToolsEntries?: () => ReadonlyMap<ToolSet | IToolData, boolean>,
token?: CancellationToken
@@ -203,6 +205,7 @@ export async function showToolsPicker(
const editorService = accessor.get(IEditorService);
const mcpWorkbenchService = accessor.get(IMcpWorkbenchService);
const toolsService = accessor.get(ILanguageModelToolsService);
const telemetryService = accessor.get(ITelemetryService);
const toolLimit = accessor.get(IContextKeyService).getContextKeyValue<number>(ChatContextKeys.chatToolGroupingThreshold.key);
const mcpServerByTool = new Map<string, IMcpServer>();
@@ -593,11 +596,45 @@ export async function showToolsPicker(
}));
}
// Capture initial state for telemetry comparison
const initialStateString = serializeToolsState(collectResults());
treePicker.show();
await Promise.race([Event.toPromise(Event.any(treePicker.onDidHide, didAcceptFinalItem.event), store)]);
// Send telemetry whether the tool selection changed
sendDidChangeEvent(source, telemetryService, initialStateString !== serializeToolsState(collectResults()));
store.dispose();
return didAccept ? collectResults() : undefined;
}
function serializeToolsState(state: ReadonlyMap<IToolData | ToolSet, boolean>): string {
const entries: [string, boolean][] = [];
state.forEach((value, key) => {
entries.push([key.id, value]);
});
entries.sort((a, b) => a[0].localeCompare(b[0]));
return JSON.stringify(entries);
}
function sendDidChangeEvent(source: string, telemetryService: ITelemetryService, changed: boolean): void {
type ToolPickerClosedEvent = {
changed: boolean;
source: string;
};
type ToolPickerClosedClassification = {
changed: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether the user changed the tool selection from the initial state.' };
source: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The source of the tool picker event.' };
owner: 'benibenj';
comment: 'Tracks whether users modify tool selection in the tool picker.';
};
telemetryService.publicLog2<ToolPickerClosedEvent, ToolPickerClosedClassification>('chatToolPickerClosed', {
source,
changed,
});
}
src/vs/workbench/contrib/chat/browser/promptSyntax/promptToolsCodeLensProvider.ts
+1 -1
View File
@@ -85,7 +85,7 @@ class PromptToolsCodeLensProvider extends Disposable implements CodeLensProvider
private async updateTools(model: ITextModel, range: Range, selectedTools: readonly string[], target: string | undefined): Promise<void> {
const selectedToolsNow = () => this.languageModelToolsService.toToolAndToolSetEnablementMap(selectedTools, target);
const newSelectedAfter = await this.instantiationService.invokeFunction(showToolsPicker, localize('placeholder', "Select tools"), undefined, selectedToolsNow);
const newSelectedAfter = await this.instantiationService.invokeFunction(showToolsPicker, localize('placeholder', "Select tools"), 'codeLens', undefined, selectedToolsNow);
if (!newSelectedAfter) {
return;
}