Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-06-03 22:25:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Nudge model to avoid giving notebook JSON into edit tool (#997)

Browse Source 
* Nudge model to avoid giving notebook JSON into edit tool

* Nudge model to avoid giving notebook JSON into edit tool
This commit is contained in:
Don Jayamanne
2025-09-10 11:02:53 +10:00
committed by GitHub
parent 71af313b26
commit 6444498657
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/copilot/src/extension/tools/node/editNotebookTool.tsx
+8 -1
View File
@@ -18,7 +18,7 @@ import { IPromptPathRepresentationService } from '../../../platform/prompts/comm
import { ITelemetryService } from '../../../platform/telemetry/common/telemetry';
import { IWorkspaceService } from '../../../platform/workspace/common/workspaceService';
import { createSha256Hash } from '../../../util/common/crypto';
import { findCell, findNotebook } from '../../../util/common/notebooks';
import { findCell, findNotebook, isJupyterNotebook } from '../../../util/common/notebooks';
import { findLast } from '../../../util/vs/base/common/arraysFind';
import { raceCancellation, StatefulPromise } from '../../../util/vs/base/common/async';
import { isCancellationError } from '../../../util/vs/base/common/errors';
@@ -317,6 +317,13 @@ export class EditNotebookTool implements ICopilotTool<IEditNotebookToolParams> {
if (newCode === undefined) {
throw new ErrorWithTelemetrySafeReason('None of the edits were applied as newCode is required for insert operation', 'missingNewCode');
}
if (newCode.length && isJupyterNotebook(notebook)) {
if (newCode.startsWith('{') && newCode.includes('"cell_type') && newCode.includes('"source') && newCode.endsWith('}')) {
// Possible the entire notebook JSON was provided as newCode.
// This is not supported.
throw new ErrorWithTelemetrySafeReason('When inserting cell(s) do NOT provide the entire notebook JSON as newCode. Provide the code (as plain text) for the cell instead.', 'gotEntireNotebookJson');
}
}
break;
case 'delete':
if (!id) {
extensions/copilot/src/util/common/notebooks.ts
+4
View File
@@ -115,6 +115,10 @@ export function isJupyterNotebookUri(uri: vscode.Uri): boolean {
return uri.path.endsWith('.ipynb');
}
export function isJupyterNotebook(notebook: vscode.NotebookDocument): boolean {
return notebook.notebookType === 'jupyter-notebook';
}
export function serializeNotebookDocument(document: vscode.NotebookDocument, features: { cell_uri_fragment?: boolean } = {}): string {
return JSON.stringify({