Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 17:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #32032 from Microsoft/amqi/update-window-shellname

Browse Source 
Fix NPE
This commit is contained in:
Rob Lourens
2017-08-04 10:06:23 -07:00
committed by GitHub
parent 75eadfbd4b e3ba8a48c1
commit 6feff11ed0
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts
+5 -1
View File
@@ -161,7 +161,11 @@ export class TerminalInstance implements ITerminalInstance {
this._createXterm();
if (platform.isWindows) {
this._processReady.then(() => this._windowsShellHelper = new WindowsShellHelper(this._processId, this._shellLaunchConfig.executable, this, this._xterm));
this._processReady.then(() => {
if (!this._isDisposed) {
this._windowsShellHelper = new WindowsShellHelper(this._processId, this._shellLaunchConfig.executable, this, this._xterm);
}
});
}
// Only attach xterm.js to the DOM if the terminal panel has been opened before.