Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 09:08:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix package.json Auto complete

Browse Source 
Fixes #17342

**Bug**
I believe that 739d8ca77f introduced a regression for package.json auto complete where we end up inserting the text `*` for the package.version

**Fix**
Insert `""` instead of star to match previous behavior better
This commit is contained in:
Matt Bierner
2016-12-16 14:03:09 -08:00
parent 8ca9455e9f
commit 76007c48fd
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/javascript/src/features/packageJSONContribution.ts
+2 -2
View File
@@ -67,7 +67,7 @@ export class PackageJSONContribution implements IJSONContribution {
let name = keys[0]; let name = keys[0];
let insertText = new SnippetString().appendText(JSON.stringify(name)); let insertText = new SnippetString().appendText(JSON.stringify(name));
if (addValue) { if (addValue) {
insertText.appendText(': ').appendPlaceholder('*'); insertText.appendText(': "').appendPlaceholder('').appendText('"');
if (!isLast) { if (!isLast) {
insertText.appendText(','); insertText.appendText(',');
} }
@@ -99,7 +99,7 @@ export class PackageJSONContribution implements IJSONContribution {
this.mostDependedOn.forEach((name) => { this.mostDependedOn.forEach((name) => {
let insertText = new SnippetString().appendText(JSON.stringify(name)); let insertText = new SnippetString().appendText(JSON.stringify(name));
if (addValue) { if (addValue) {
insertText.appendText(': ').appendPlaceholder('*'); insertText.appendText(': "').appendPlaceholder('').appendText('"');
if (!isLast) { if (!isLast) {
insertText.appendText(','); insertText.appendText(',');
} }