Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 17:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

add telemetry comments (#150317)

Browse Source
This commit is contained in:
Megan Rogge
2022-05-24 16:10:38 -07:00
committed by GitHub
parent 0226ad3aa7
commit 7635c51d7f
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/platform/terminal/common/xterm/shellIntegrationAddon.ts
+2 -2
View File
@@ -144,7 +144,7 @@ export class ShellIntegrationAddon extends Disposable implements IShellIntegrati
private _handleVSCodeSequence(data: string): boolean {
const didHandle = this._doHandleVSCodeSequence(data);
if (!this._hasUpdatedTelemetry && didHandle) {
this._telemetryService?.publicLog2<{}, { owner: 'meganrogge' }>('terminal/shellIntegrationActivationSucceeded');
this._telemetryService?.publicLog2<{}, { owner: 'meganrogge'; comment: 'Indicates shell integration was activated' }>('terminal/shellIntegrationActivationSucceeded');
this._hasUpdatedTelemetry = true;
if (this._activationTimeout !== undefined) {
clearTimeout(this._activationTimeout);
@@ -232,7 +232,7 @@ export class ShellIntegrationAddon extends Disposable implements IShellIntegrati
private async _ensureCapabilitiesOrAddFailureTelemetry(): Promise<void> {
this._activationTimeout = setTimeout(() => {
if (!this.capabilities.get(TerminalCapability.CommandDetection) && !this.capabilities.get(TerminalCapability.CwdDetection)) {
this._telemetryService?.publicLog2<{}, { owner: 'meganrogge' }>('terminal/shellIntegrationActivationTimeout');
this._telemetryService?.publicLog2<{}, { owner: 'meganrogge'; comment: 'Indicates shell integration activation did not occur within 10 seconds' }>('terminal/shellIntegrationActivationTimeout');
this._logService.warn('Shell integration failed to add capabilities within 10 seconds');
}
this._hasUpdatedTelemetry = true;
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
+1 -1
View File
@@ -1634,7 +1634,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
}
if (failedShellIntegrationInjection) {
this._telemetryService.publicLog2<{}, { owner: 'meganrogge' }>('terminal/shellIntegrationFailureProcessExit');
this._telemetryService.publicLog2<{}, { owner: 'meganrogge'; comment: 'Indicates the process exited when created with shell integration args' }>('terminal/shellIntegrationFailureProcessExit');
}
// First onExit to consumers, this can happen after the terminal has already been disposed.
src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts
+1 -1
View File
@@ -335,7 +335,7 @@ export class TerminalProcessManager extends Disposable implements ITerminalProce
this._hasChildProcesses = value;
break;
case ProcessPropertyType.FailedShellIntegrationActivation:
this._telemetryService?.publicLog2<{}, { owner: 'meganrogge' }>('terminal/shellIntegrationActivationFailureCustomArgs');
this._telemetryService?.publicLog2<{}, { owner: 'meganrogge'; comment: 'Indicates shell integration was not activated because of custom args' }>('terminal/shellIntegrationActivationFailureCustomArgs');
break;
}
this._onDidChangeProperty.fire({ type, value });