Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 02:58:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Use a config interface for terminal creation in API"

Browse Source 
We're sticking with simple for now, an overload can be used if a config object
is necessary later.

This reverts commit 873b3d0b38.
This commit is contained in:
Daniel Imms
2016-09-01 14:00:10 -07:00
parent aae56e2010
commit 7bd499af9b
3 changed files with 6 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/api/node/extHost.api.impl.ts
View File

@@ -258,8 +258,8 @@ export class ExtHostAPIImplementation {
createOutputChannel(name: string): vscode.OutputChannel {
return extHostOutputService.createOutputChannel(name);
},
createTerminal(configuration: vscode.TerminalConfiguration): vscode.Terminal {
return extHostTerminalService.createTerminal(configuration);
createTerminal(name?: string): vscode.Terminal {
return extHostTerminalService.createTerminal(name);
}
};

4
src/vs/workbench/api/node/extHostTerminalService.ts
View File

@@ -85,8 +85,8 @@ export class ExtHostTerminalService {
this._proxy = threadService.get(MainContext.MainThreadTerminalService);
}
public createTerminal(configuration: vscode.TerminalConfiguration): vscode.Terminal {
return new ExtHostTerminal(this._proxy, -1, configuration.name);
public createTerminal(name?: string): vscode.Terminal {
return new ExtHostTerminal(this._proxy, -1, name);
}
}