Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-08-27 21:09:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

allow provider to give their own accessible view help content (#194049)

Browse Source 
* fix #193451

* clean up
This commit is contained in:
Megan Rogge
2023-09-26 04:40:38 +01:00
committed by GitHub
parent dd4ed00c37
commit 85eda164f8
3 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/accessibility/browser/accessibleView.ts
+3 -1
View File
@@ -102,6 +102,7 @@ export interface IAccessibleViewOptions {
language?: string;
type: AccessibleViewType;
positionBottom?: boolean;
customHelp?: () => string;
}
export class AccessibleView extends Disposable {
@@ -506,9 +507,10 @@ export class AccessibleView extends Disposable {
}
const currentProvider = Object.assign({}, this._currentProvider);
currentProvider.provideContent = this._currentProvider.provideContent.bind(currentProvider);
currentProvider.options = Object.assign({}, currentProvider.options);
const accessibleViewHelpProvider: IAccessibleContentProvider = {
provideContent: () => this._getAccessibleViewHelpDialogContent(this._goToSymbolsSupported()),
provideContent: () => currentProvider.options.customHelp ? currentProvider?.options.customHelp() : this._getAccessibleViewHelpDialogContent(this._goToSymbolsSupported()),
onClose: () => this.show(currentProvider),
options: { type: AccessibleViewType.Help },
verbositySettingKey: this._currentProvider.verbositySettingKey
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
+3 -1
View File
@@ -119,7 +119,9 @@ export class TerminalAccessibleViewContribution extends Disposable implements IT
this._bufferTracker = this._register(this._instantiationService.createInstance(BufferContentTracker, this._xterm));
}
if (!this._bufferProvider) {
this._bufferProvider = this._register(this._instantiationService.createInstance(TerminalAccessibleBufferProvider, this._instance, this._bufferTracker));
this._bufferProvider = this._register(this._instantiationService.createInstance(TerminalAccessibleBufferProvider, this._instance, this._bufferTracker, () => {
return this._register(this._instantiationService.createInstance(TerminalAccessibleContentProvider, this._instance, this._xterm!)).provideContent();
}));
}
this._accessibleViewService.show(this._bufferProvider);
}
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBufferProvider.ts
+2
View File
@@ -22,12 +22,14 @@ export class TerminalAccessibleBufferProvider extends DisposableStore implements
constructor(
private readonly _instance: Pick<ITerminalInstance, 'onDidRunText' | 'focus' | 'shellType' | 'capabilities' | 'onDidRequestFocus' | 'resource'>,
private _bufferTracker: BufferContentTracker,
customHelp: () => string,
@IModelService _modelService: IModelService,
@IConfigurationService _configurationService: IConfigurationService,
@IContextKeyService _contextKeyService: IContextKeyService,
@ITerminalService _terminalService: ITerminalService
) {
super();
this.options.customHelp = customHelp;
}
onClose() {