mirror of
https://github.com/microsoft/vscode.git
synced 2026-05-08 09:08:48 +01:00
preps for ensureNoDisposablesAreLeakedInTestSuite (#192603)
#190503 preps for ensureNoDisposablesAreLeakedInTestSuite
This commit is contained in:
Sandeep Somavarapu
committed by
GitHub
GitHub
parent
b257cce9e7
commit
8627ee4504
+21
-12
@@ -9,7 +9,7 @@ import { CancelablePromise, createCancelablePromise, Promises, raceCancellablePr
|
||||
import { CancellationToken } from 'vs/base/common/cancellation';
|
||||
import { isCancellationError } from 'vs/base/common/errors';
|
||||
import { Emitter, Event } from 'vs/base/common/event';
|
||||
import { DisposableStore, isDisposable, MutableDisposable } from 'vs/base/common/lifecycle';
|
||||
import { Disposable, DisposableStore, isDisposable, MutableDisposable, toDisposable } from 'vs/base/common/lifecycle';
|
||||
import { localize } from 'vs/nls';
|
||||
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
|
||||
import { areSameExtensions } from 'vs/platform/extensionManagement/common/extensionManagementUtil';
|
||||
@@ -50,12 +50,12 @@ type RecommendationsNotificationActions = {
|
||||
onDidNeverShowRecommendedExtensionsAgain(extensions: IExtension[]): void;
|
||||
};
|
||||
|
||||
class RecommendationsNotification {
|
||||
class RecommendationsNotification extends Disposable {
|
||||
|
||||
private _onDidClose = new Emitter<void>();
|
||||
private _onDidClose = this._register(new Emitter<void>());
|
||||
readonly onDidClose = this._onDidClose.event;
|
||||
|
||||
private _onDidChangeVisibility = new Emitter<boolean>();
|
||||
private _onDidChangeVisibility = this._register(new Emitter<boolean>());
|
||||
readonly onDidChangeVisibility = this._onDidChangeVisibility.event;
|
||||
|
||||
private notificationHandle: INotificationHandle | undefined;
|
||||
@@ -66,7 +66,9 @@ class RecommendationsNotification {
|
||||
private readonly message: string,
|
||||
private readonly choices: IPromptChoice[],
|
||||
private readonly notificationService: INotificationService
|
||||
) { }
|
||||
) {
|
||||
super();
|
||||
}
|
||||
|
||||
show(): void {
|
||||
if (!this.notificationHandle) {
|
||||
@@ -87,8 +89,8 @@ class RecommendationsNotification {
|
||||
return this.cancelled;
|
||||
}
|
||||
|
||||
private onDidCloseDisposable = new MutableDisposable();
|
||||
private onDidChangeVisibilityDisposable = new MutableDisposable();
|
||||
private onDidCloseDisposable = this._register(new MutableDisposable());
|
||||
private onDidChangeVisibilityDisposable = this._register(new MutableDisposable());
|
||||
private updateNotificationHandle(notificationHandle: INotificationHandle) {
|
||||
this.onDidCloseDisposable.clear();
|
||||
this.onDidChangeVisibilityDisposable.clear();
|
||||
@@ -110,7 +112,7 @@ class RecommendationsNotification {
|
||||
type PendingRecommendationsNotification = { recommendationsNotification: RecommendationsNotification; source: RecommendationSource; token: CancellationToken };
|
||||
type VisibleRecommendationsNotification = { recommendationsNotification: RecommendationsNotification; source: RecommendationSource; from: number };
|
||||
|
||||
export class ExtensionRecommendationNotificationService implements IExtensionRecommendationNotificationService {
|
||||
export class ExtensionRecommendationNotificationService extends Disposable implements IExtensionRecommendationNotificationService {
|
||||
|
||||
declare readonly _serviceBrand: undefined;
|
||||
|
||||
@@ -138,7 +140,9 @@ export class ExtensionRecommendationNotificationService implements IExtensionRec
|
||||
@IExtensionIgnoredRecommendationsService private readonly extensionIgnoredRecommendationsService: IExtensionIgnoredRecommendationsService,
|
||||
@IUserDataSyncEnablementService private readonly userDataSyncEnablementService: IUserDataSyncEnablementService,
|
||||
@IWorkbenchEnvironmentService private readonly workbenchEnvironmentService: IWorkbenchEnvironmentService,
|
||||
) { }
|
||||
) {
|
||||
super();
|
||||
}
|
||||
|
||||
hasToIgnoreRecommendationNotifications(): boolean {
|
||||
const config = this.configurationService.getValue<{ ignoreRecommendations: boolean; showRecommendationsOnlyOnDemand?: boolean }>('extensions');
|
||||
@@ -255,8 +259,8 @@ export class ExtensionRecommendationNotificationService implements IExtensionRec
|
||||
}
|
||||
|
||||
return raceCancellablePromises([
|
||||
this.showRecommendationsNotification(extensions, message, searchValue, source, recommendationsNotificationActions),
|
||||
this.waitUntilRecommendationsAreInstalled(extensions)
|
||||
this._registerP(this.showRecommendationsNotification(extensions, message, searchValue, source, recommendationsNotificationActions)),
|
||||
this._registerP(this.waitUntilRecommendationsAreInstalled(extensions))
|
||||
]);
|
||||
|
||||
}
|
||||
@@ -344,7 +348,7 @@ export class ExtensionRecommendationNotificationService implements IExtensionRec
|
||||
private async doShowRecommendationsNotification(severity: Severity, message: string, choices: IPromptChoice[], source: RecommendationSource, token: CancellationToken): Promise<boolean> {
|
||||
const disposables = new DisposableStore();
|
||||
try {
|
||||
const recommendationsNotification = new RecommendationsNotification(severity, message, choices, this.notificationService);
|
||||
const recommendationsNotification = disposables.add(new RecommendationsNotification(severity, message, choices, this.notificationService));
|
||||
disposables.add(Event.once(Event.filter(recommendationsNotification.onDidChangeVisibility, e => !e))(() => this.showNextNotification()));
|
||||
if (this.visibleNotification) {
|
||||
const index = this.pendingNotificaitons.length;
|
||||
@@ -442,4 +446,9 @@ export class ExtensionRecommendationNotificationService implements IExtensionRec
|
||||
private setIgnoreRecommendationsConfig(configVal: boolean) {
|
||||
this.configurationService.updateValue('extensions.ignoreRecommendations', configVal);
|
||||
}
|
||||
|
||||
private _registerP<T>(o: CancelablePromise<T>): CancelablePromise<T> {
|
||||
this._register(toDisposable(() => o.cancel()));
|
||||
return o;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -3,7 +3,7 @@
|
||||
* Licensed under the MIT License. See License.txt in the project root for license information.
|
||||
*--------------------------------------------------------------------------------------------*/
|
||||
|
||||
import { Disposable } from 'vs/base/common/lifecycle';
|
||||
import { Disposable, toDisposable } from 'vs/base/common/lifecycle';
|
||||
import { IExtensionManagementService, IExtensionGalleryService, InstallOperation, InstallExtensionResult } from 'vs/platform/extensionManagement/common/extensionManagement';
|
||||
import { IExtensionRecommendationsService, ExtensionRecommendationReason, IExtensionIgnoredRecommendationsService } from 'vs/workbench/services/extensionRecommendations/common/extensionRecommendations';
|
||||
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
|
||||
@@ -20,7 +20,7 @@ import { LanguageRecommendations } from 'vs/workbench/contrib/extensions/browser
|
||||
import { ExtensionRecommendation } from 'vs/workbench/contrib/extensions/browser/extensionRecommendations';
|
||||
import { ConfigBasedRecommendations } from 'vs/workbench/contrib/extensions/browser/configBasedRecommendations';
|
||||
import { IExtensionRecommendationNotificationService } from 'vs/platform/extensionRecommendations/common/extensionRecommendations';
|
||||
import { timeout } from 'vs/base/common/async';
|
||||
import { CancelablePromise, timeout } from 'vs/base/common/async';
|
||||
import { URI } from 'vs/base/common/uri';
|
||||
import { WebRecommendations } from 'vs/workbench/contrib/extensions/browser/webRecommendations';
|
||||
import { IExtensionsWorkbenchService } from 'vs/workbench/contrib/extensions/common/extensions';
|
||||
@@ -276,8 +276,13 @@ export class ExtensionRecommendationsService extends Disposable implements IExte
|
||||
.filter(extensionId => this.isExtensionAllowedToBeRecommended(extensionId));
|
||||
|
||||
if (allowedRecommendations.length) {
|
||||
await timeout(5000);
|
||||
await this._registerP(timeout(5000));
|
||||
await this.extensionRecommendationNotificationService.promptWorkspaceRecommendations(allowedRecommendations);
|
||||
}
|
||||
}
|
||||
|
||||
private _registerP<T>(o: CancelablePromise<T>): CancelablePromise<T> {
|
||||
this._register(toDisposable(() => o.cancel()));
|
||||
return o;
|
||||
}
|
||||
}
|
||||
|
||||
+34
-37
@@ -61,6 +61,7 @@ import { VSBuffer } from 'vs/base/common/buffer';
|
||||
import { platform } from 'vs/base/common/platform';
|
||||
import { arch } from 'vs/base/common/process';
|
||||
import { runWithFakedTimers } from 'vs/base/test/common/timeTravelScheduler';
|
||||
import { DisposableStore } from 'vs/base/common/lifecycle';
|
||||
|
||||
const mockExtensionGallery: IGalleryExtension[] = [
|
||||
aGalleryExtension('MockExtension1', {
|
||||
@@ -180,6 +181,7 @@ function aGalleryExtension(name: string, properties: any = {}, galleryExtensionP
|
||||
}
|
||||
|
||||
suite('ExtensionRecommendationsService Test', () => {
|
||||
const disposableStore = new DisposableStore();
|
||||
let workspaceService: IWorkspaceContextService;
|
||||
let instantiationService: TestInstantiationService;
|
||||
let testConfigurationService: TestConfigurationService;
|
||||
@@ -189,18 +191,19 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
uninstallEvent: Emitter<UninstallExtensionEvent>,
|
||||
didUninstallEvent: Emitter<DidUninstallExtensionEvent>;
|
||||
let prompted: boolean;
|
||||
const promptedEmitter = new Emitter<void>();
|
||||
let promptedEmitter: Emitter<void>;
|
||||
let onModelAddedEvent: Emitter<ITextModel>;
|
||||
|
||||
suiteSetup(() => {
|
||||
instantiationService = new TestInstantiationService();
|
||||
installEvent = new Emitter<InstallExtensionEvent>();
|
||||
didInstallEvent = new Emitter<readonly InstallExtensionResult[]>();
|
||||
uninstallEvent = new Emitter<UninstallExtensionEvent>();
|
||||
didUninstallEvent = new Emitter<DidUninstallExtensionEvent>();
|
||||
setup(() => {
|
||||
instantiationService = disposableStore.add(new TestInstantiationService());
|
||||
promptedEmitter = disposableStore.add(new Emitter<void>());
|
||||
installEvent = disposableStore.add(new Emitter<InstallExtensionEvent>());
|
||||
didInstallEvent = disposableStore.add(new Emitter<readonly InstallExtensionResult[]>());
|
||||
uninstallEvent = disposableStore.add(new Emitter<UninstallExtensionEvent>());
|
||||
didUninstallEvent = disposableStore.add(new Emitter<DidUninstallExtensionEvent>());
|
||||
instantiationService.stub(IExtensionGalleryService, ExtensionGalleryService);
|
||||
instantiationService.stub(ISharedProcessService, TestSharedProcessService);
|
||||
instantiationService.stub(ILifecycleService, new TestLifecycleService());
|
||||
instantiationService.stub(ILifecycleService, disposableStore.add(new TestLifecycleService()));
|
||||
testConfigurationService = new TestConfigurationService();
|
||||
instantiationService.stub(IConfigurationService, testConfigurationService);
|
||||
instantiationService.stub(INotificationService, new TestNotificationService());
|
||||
@@ -222,11 +225,11 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
extensions: [],
|
||||
async whenInstalledExtensionsRegistered() { return true; }
|
||||
});
|
||||
instantiationService.stub(IWorkbenchExtensionEnablementService, new TestExtensionEnablementService(instantiationService));
|
||||
instantiationService.stub(IWorkbenchExtensionEnablementService, disposableStore.add(new TestExtensionEnablementService(instantiationService)));
|
||||
instantiationService.stub(ITelemetryService, NullTelemetryService);
|
||||
instantiationService.stub(IURLService, NativeURLService);
|
||||
instantiationService.stub(IWorkspaceTagsService, new NoOpWorkspaceTagsService());
|
||||
instantiationService.stub(IStorageService, new TestStorageService());
|
||||
instantiationService.stub(IStorageService, disposableStore.add(new TestStorageService()));
|
||||
instantiationService.stub(ILogService, new NullLogService());
|
||||
instantiationService.stub(IProductService, <Partial<IProductService>>{
|
||||
extensionTips: {
|
||||
@@ -275,13 +278,11 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
},
|
||||
});
|
||||
|
||||
instantiationService.set(IExtensionsWorkbenchService, instantiationService.createInstance(ExtensionsWorkbenchService));
|
||||
instantiationService.stub(IExtensionTipsService, instantiationService.createInstance(TestExtensionTipsService));
|
||||
instantiationService.set(IExtensionsWorkbenchService, disposableStore.add(instantiationService.createInstance(ExtensionsWorkbenchService)));
|
||||
instantiationService.stub(IExtensionTipsService, disposableStore.add(instantiationService.createInstance(TestExtensionTipsService)));
|
||||
|
||||
onModelAddedEvent = new Emitter<ITextModel>();
|
||||
});
|
||||
|
||||
setup(() => {
|
||||
instantiationService.stub(IEnvironmentService, <Partial<IEnvironmentService>>{});
|
||||
instantiationService.stubPromise(IExtensionManagementService, 'getInstalled', []);
|
||||
instantiationService.stub(IExtensionGalleryService, 'isEnabled', true);
|
||||
@@ -307,11 +308,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
});
|
||||
});
|
||||
|
||||
teardown(() => (<ExtensionRecommendationsService>testObject).dispose());
|
||||
|
||||
suiteTeardown(() => {
|
||||
instantiationService.dispose();
|
||||
});
|
||||
teardown(() => disposableStore.clear());
|
||||
|
||||
function setUpFolderWorkspace(folderName: string, recommendedExtensions: string[], ignoredRecommendations: string[] = []): Promise<void> {
|
||||
return setUpFolder(folderName, recommendedExtensions, ignoredRecommendations);
|
||||
@@ -320,9 +317,9 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
async function setUpFolder(folderName: string, recommendedExtensions: string[], ignoredRecommendations: string[] = []): Promise<void> {
|
||||
const ROOT = URI.file('tests').with({ scheme: 'vscode-tests' });
|
||||
const logService = new NullLogService();
|
||||
const fileService = new FileService(logService);
|
||||
const fileSystemProvider = new InMemoryFileSystemProvider();
|
||||
fileService.registerProvider(ROOT.scheme, fileSystemProvider);
|
||||
const fileService = disposableStore.add(new FileService(logService));
|
||||
const fileSystemProvider = disposableStore.add(new InMemoryFileSystemProvider());
|
||||
disposableStore.add(fileService.registerProvider(ROOT.scheme, fileSystemProvider));
|
||||
|
||||
const folderDir = joinPath(ROOT, folderName);
|
||||
const workspaceSettingsDir = joinPath(folderDir, '.vscode');
|
||||
@@ -338,14 +335,14 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
instantiationService.stub(IFileService, fileService);
|
||||
workspaceService = new TestContextService(myWorkspace);
|
||||
instantiationService.stub(IWorkspaceContextService, workspaceService);
|
||||
instantiationService.stub(IWorkspaceExtensionsConfigService, instantiationService.createInstance(WorkspaceExtensionsConfigService));
|
||||
instantiationService.stub(IExtensionIgnoredRecommendationsService, instantiationService.createInstance(ExtensionIgnoredRecommendationsService));
|
||||
instantiationService.stub(IExtensionRecommendationNotificationService, instantiationService.createInstance(ExtensionRecommendationNotificationService));
|
||||
instantiationService.stub(IWorkspaceExtensionsConfigService, disposableStore.add(instantiationService.createInstance(WorkspaceExtensionsConfigService)));
|
||||
instantiationService.stub(IExtensionIgnoredRecommendationsService, disposableStore.add(instantiationService.createInstance(ExtensionIgnoredRecommendationsService)));
|
||||
instantiationService.stub(IExtensionRecommendationNotificationService, disposableStore.add(instantiationService.createInstance(ExtensionRecommendationNotificationService)));
|
||||
}
|
||||
|
||||
function testNoPromptForValidRecommendations(recommendations: string[]) {
|
||||
return setUpFolderWorkspace('myFolder', recommendations).then(() => {
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
return testObject.activationPromise.then(() => {
|
||||
assert.strictEqual(Object.keys(testObject.getAllRecommendationsWithReason()).length, recommendations.length);
|
||||
assert.ok(!prompted);
|
||||
@@ -355,7 +352,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
|
||||
function testNoPromptOrRecommendationsForValidRecommendations(recommendations: string[]) {
|
||||
return setUpFolderWorkspace('myFolder', mockTestData.validRecommendedExtensions).then(() => {
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
assert.ok(!prompted);
|
||||
|
||||
return testObject.getWorkspaceRecommendations().then(() => {
|
||||
@@ -384,7 +381,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
|
||||
test('ExtensionRecommendationsService: Prompt for valid workspace recommendations', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
|
||||
await setUpFolderWorkspace('myFolder', mockTestData.recommendedExtensions);
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
|
||||
await Event.toPromise(promptedEmitter.event);
|
||||
const recommendations = Object.keys(testObject.getAllRecommendationsWithReason());
|
||||
@@ -413,7 +410,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
test('ExtensionRecommendationsService: No Prompt for valid workspace recommendations if showRecommendationsOnlyOnDemand is set', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
|
||||
testConfigurationService.setUserConfiguration(ConfigurationKey, { showRecommendationsOnlyOnDemand: true });
|
||||
return setUpFolderWorkspace('myFolder', mockTestData.validRecommendedExtensions).then(() => {
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
return testObject.activationPromise.then(() => {
|
||||
assert.ok(!prompted);
|
||||
});
|
||||
@@ -431,7 +428,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
instantiationService.get(IStorageService).store('extensionsAssistant/ignored_recommendations', '["ms-dotnettools.csharp", "mockpublisher2.mockextension2"]', StorageScope.PROFILE, StorageTarget.MACHINE);
|
||||
|
||||
return setUpFolderWorkspace('myFolder', mockTestData.validRecommendedExtensions).then(() => {
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
return testObject.activationPromise.then(() => {
|
||||
const recommendations = testObject.getAllRecommendationsWithReason();
|
||||
assert.ok(!recommendations['ms-dotnettools.csharp']); // stored recommendation that has been globally ignored
|
||||
@@ -449,7 +446,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
instantiationService.get(IStorageService).store('extensionsAssistant/recommendations', storedRecommendations, StorageScope.PROFILE, StorageTarget.MACHINE);
|
||||
|
||||
return setUpFolderWorkspace('myFolder', mockTestData.validRecommendedExtensions, ignoredRecommendations).then(() => {
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
return testObject.activationPromise.then(() => {
|
||||
const recommendations = testObject.getAllRecommendationsWithReason();
|
||||
assert.ok(!recommendations['ms-dotnettools.csharp']); // stored recommendation that has been workspace ignored
|
||||
@@ -471,7 +468,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
storageService.store('extensionsAssistant/ignored_recommendations', globallyIgnoredRecommendations, StorageScope.PROFILE, StorageTarget.MACHINE);
|
||||
|
||||
await setUpFolderWorkspace('myFolder', mockTestData.validRecommendedExtensions, workspaceIgnoredRecommendations);
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
await testObject.activationPromise;
|
||||
|
||||
const recommendations = testObject.getAllRecommendationsWithReason();
|
||||
@@ -489,7 +486,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
|
||||
await setUpFolderWorkspace('myFolder', mockTestData.validRecommendedExtensions);
|
||||
const extensionIgnoredRecommendationsService = instantiationService.get(IExtensionIgnoredRecommendationsService);
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
await testObject.activationPromise;
|
||||
|
||||
let recommendations = testObject.getAllRecommendationsWithReason();
|
||||
@@ -521,9 +518,9 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
storageService.store('extensionsAssistant/ignored_recommendations', '["ms-vscode.vscode"]', StorageScope.PROFILE, StorageTarget.MACHINE);
|
||||
|
||||
await setUpFolderWorkspace('myFolder', []);
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
const extensionIgnoredRecommendationsService = instantiationService.get(IExtensionIgnoredRecommendationsService);
|
||||
extensionIgnoredRecommendationsService.onDidChangeGlobalIgnoredRecommendation(changeHandlerTarget);
|
||||
disposableStore.add(extensionIgnoredRecommendationsService.onDidChangeGlobalIgnoredRecommendation(changeHandlerTarget));
|
||||
extensionIgnoredRecommendationsService.toggleGlobalIgnoredRecommendation(ignoredExtensionId, true);
|
||||
await testObject.activationPromise;
|
||||
|
||||
@@ -536,7 +533,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
instantiationService.get(IStorageService).store('extensionsAssistant/recommendations', storedRecommendations, StorageScope.PROFILE, StorageTarget.MACHINE);
|
||||
|
||||
return setUpFolderWorkspace('myFolder', []).then(() => {
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
return testObject.activationPromise.then(() => {
|
||||
const recommendations = testObject.getFileBasedRecommendations();
|
||||
assert.strictEqual(recommendations.length, 2);
|
||||
@@ -555,7 +552,7 @@ suite('ExtensionRecommendationsService Test', () => {
|
||||
instantiationService.get(IStorageService).store('extensionsAssistant/recommendations', storedRecommendations, StorageScope.PROFILE, StorageTarget.MACHINE);
|
||||
|
||||
await setUpFolderWorkspace('myFolder', []);
|
||||
testObject = instantiationService.createInstance(ExtensionRecommendationsService);
|
||||
testObject = disposableStore.add(instantiationService.createInstance(ExtensionRecommendationsService));
|
||||
await testObject.activationPromise;
|
||||
|
||||
const recommendations = testObject.getFileBasedRecommendations();
|
||||
|
||||
Reference in New Issue
Block a user