Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-15 07:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add debug logging for file dialog default path selection (#289977)

Browse Source 
* Initial plan

* Add debug logging for file dialog default path selection

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
This commit is contained in:
Copilot
2026-01-26 15:40:38 +00:00
committed by GitHub
parent a3f7ea8588
commit 864a3b98f8
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/vs/workbench/services/dialogs/browser/abstractFileDialogService.ts
View File

@@ -65,12 +65,17 @@ export abstract class AbstractFileDialogService implements IFileDialogService {
// ...then for last active file root
if (!candidate) {
candidate = this.historyService.getLastActiveWorkspaceRoot(schemeFilter, authorityFilter);
if (candidate) {
this.logService.debug(`[FileDialogService] Default file path using last active workspace root: ${candidate}`);
}
} else {
this.logService.debug(`[FileDialogService] Default file path using parent of last active file: ${candidate}`);
candidate = resources.dirname(candidate);
}
if (!candidate) {
candidate = await this.preferredHome(schemeFilter);
this.logService.debug(`[FileDialogService] Default file path using preferred home: ${candidate}`);
}
return candidate;
@@ -84,10 +89,17 @@ export abstract class AbstractFileDialogService implements IFileDialogService {
// ...then for last active file
if (!candidate) {
candidate = this.historyService.getLastActiveFile(schemeFilter, authorityFilter);
if (candidate) {
this.logService.debug(`[FileDialogService] Default folder path using parent of last active file: ${candidate}`);
}
} else {
this.logService.debug(`[FileDialogService] Default folder path using last active workspace root: ${candidate}`);
}
if (!candidate) {
return this.preferredHome(schemeFilter);
const preferredHome = await this.preferredHome(schemeFilter);
this.logService.debug(`[FileDialogService] Default folder path using preferred home: ${preferredHome}`);
return preferredHome;
}
return resources.dirname(candidate);
@@ -97,18 +109,25 @@ export abstract class AbstractFileDialogService implements IFileDialogService {
const preferLocal = schemeFilter === Schemas.file;
const preferredHomeConfig = this.configurationService.inspect<string>('files.dialog.defaultPath');
const preferredHomeCandidate = preferLocal ? preferredHomeConfig.userLocalValue : preferredHomeConfig.userRemoteValue;
this.logService.debug(`[FileDialogService] Preferred home: preferLocal=${preferLocal}, userLocalValue=${preferredHomeConfig.userLocalValue}, userRemoteValue=${preferredHomeConfig.userRemoteValue}`);
if (preferredHomeCandidate) {
const isPreferredHomeCandidateAbsolute = preferLocal ? localPathIsAbsolute(preferredHomeCandidate) : (await this.pathService.path).isAbsolute(preferredHomeCandidate);
if (isPreferredHomeCandidateAbsolute) {
const preferredHomeNormalized = preferLocal ? localPathNormalize(preferredHomeCandidate) : (await this.pathService.path).normalize(preferredHomeCandidate);
const preferredHome = resources.toLocalResource(await this.pathService.fileURI(preferredHomeNormalized), this.environmentService.remoteAuthority, this.pathService.defaultUriScheme);
if (await this.fileService.exists(preferredHome)) {
this.logService.debug(`[FileDialogService] Preferred home using files.dialog.defaultPath setting: ${preferredHome}`);
return preferredHome;
}
this.logService.debug(`[FileDialogService] Preferred home files.dialog.defaultPath path does not exist: ${preferredHome}`);
} else {
this.logService.debug(`[FileDialogService] Preferred home files.dialog.defaultPath is not absolute: ${preferredHomeCandidate}`);
}
}
return this.pathService.userHome({ preferLocal });
const userHome = this.pathService.userHome({ preferLocal });
this.logService.debug(`[FileDialogService] Preferred home using user home: ${userHome}`);
return userHome;
}
async defaultWorkspacePath(schemeFilter = this.getSchemeFilterForWindow()): Promise<URI> {