Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-05 20:44:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Support multiple configurations in extension editor (#54116)

Browse Source 
* Support multiple configurations in extension editor

* Check array only if properties not found

* Allow contributes.configuration to be an array
This commit is contained in:
Ramya Rao
2018-07-13 15:28:59 -07:00
committed by GitHub
parent c150d0d42d
commit 8b9495d494
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/platform/extensionManagement/common/extensionManagement.ts
+1 -1
View File
@@ -96,7 +96,7 @@ export interface IColor {
export interface IExtensionContributions {
commands?: ICommand[];
configuration?: IConfiguration;
configuration?: IConfiguration | IConfiguration[];
debuggers?: IDebugger[];
grammars?: IGrammar[];
jsonValidation?: IJSONValidation[];
src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
+8 -1
View File
@@ -667,7 +667,14 @@ export class ExtensionEditor extends BaseEditor {
private renderSettings(container: HTMLElement, manifest: IExtensionManifest, onDetailsToggle: Function): boolean {
const contributes = manifest.contributes;
const configuration = contributes && contributes.configuration;
const properties = configuration && configuration.properties;
let properties = {};
if (Array.isArray(configuration)) {
configuration.forEach(config => {
properties = { ...properties, ...config.properties };
});
} else if (configuration) {
properties = configuration.properties;
}
const contrib = properties ? Object.keys(properties) : [];
if (!contrib.length) {