Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-25 04:36:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adopt ensureNoDisposablesAreLeakedInTestSuite in a few files (#241462)

Browse Source 
Part of #200091
This commit is contained in:
Alex Ross
2025-02-21 12:47:29 +01:00
committed by GitHub
parent b7308ab4f1
commit 94ae470f1b
4 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
eslint.config.js
View File

@@ -224,15 +224,12 @@ export default tseslint.config(
'src/vs/platform/registry/test/common/platform.test.ts',
'src/vs/platform/workspace/test/common/workspace.test.ts',
'src/vs/platform/workspaces/test/electron-main/workspaces.test.ts',
'src/vs/workbench/api/test/browser/mainThreadConfiguration.test.ts',
'src/vs/workbench/api/test/node/extHostTunnelService.test.ts',
'src/vs/workbench/contrib/bulkEdit/test/browser/bulkCellEdits.test.ts',
'src/vs/workbench/contrib/chat/test/common/chatWordCounter.test.ts',
'src/vs/workbench/contrib/extensions/test/common/extensionQuery.test.ts',
'src/vs/workbench/contrib/notebook/test/browser/notebookExecutionService.test.ts',
'src/vs/workbench/contrib/notebook/test/browser/notebookExecutionStateService.test.ts',
'src/vs/workbench/contrib/tasks/test/common/problemMatcher.test.ts',
'src/vs/workbench/contrib/tasks/test/common/taskConfiguration.test.ts',
'src/vs/workbench/services/commands/test/common/commandService.test.ts',
'src/vs/workbench/services/userActivity/test/browser/domActivityTracker.test.ts',
'src/vs/workbench/test/browser/quickAccess.test.ts'

3
src/vs/workbench/api/test/browser/mainThreadConfiguration.test.ts
View File

@@ -15,9 +15,12 @@ import { SingleProxyRPCProtocol } from '../common/testRPCProtocol.js';
import { IConfigurationService, ConfigurationTarget } from '../../../../platform/configuration/common/configuration.js';
import { WorkspaceService } from '../../../services/configuration/browser/configurationService.js';
import { IEnvironmentService } from '../../../../platform/environment/common/environment.js';
import { ensureNoDisposablesAreLeakedInTestSuite } from '../../../../base/test/common/utils.js';
suite('MainThreadConfiguration', function () {
ensureNoDisposablesAreLeakedInTestSuite();
const proxy = {
$initializeConfiguration: () => { }
};

2
src/vs/workbench/api/test/node/extHostTunnelService.test.ts
View File

@@ -5,6 +5,7 @@
import assert from 'assert';
import { findPorts, getRootProcesses, getSockets, loadConnectionTable, loadListeningPorts, parseIpAddress, tryFindRootPorts } from '../../node/extHostTunnelService.js';
import { ensureNoDisposablesAreLeakedInTestSuite } from '../../../../base/test/common/utils.js';
const tcp =
` sl local_address rem_address st tx_queue rx_queue tr tm->when retrnsmt uid timeout inode
@@ -225,6 +226,7 @@ const psStdOut =
0 S node 1058 1056 0 80 0 - 770 pipe_w 888 9 14:43 ? 00:00:00 grep root`;
suite('ExtHostTunnelService', () => {
ensureNoDisposablesAreLeakedInTestSuite();
test('getSockets', function () {
const result = getSockets(procSockets);
assert.strictEqual(Object.keys(result).length, 75);

9
src/vs/workbench/contrib/tasks/test/common/taskConfiguration.test.ts
View File

@@ -20,6 +20,7 @@ import { IContext } from '../../../../../platform/contextkey/common/contextkey.j
import { Workspace } from '../../../../../platform/workspace/test/common/testWorkspace.js';
import { TestInstantiationService } from '../../../../../platform/instantiation/test/common/instantiationServiceMock.js';
import { ITaskDefinitionRegistry } from '../../common/taskDefinitionRegistry.js';
import { ensureNoDisposablesAreLeakedInTestSuite } from '../../../../../base/test/common/utils.js';
const workspaceFolder: WorkspaceFolder = new WorkspaceFolder({
uri: URI.file('/workspace/folderOne'),
@@ -598,6 +599,8 @@ function assertProblemPattern(actual: IProblemPattern, expected: IProblemPattern
}
suite('Tasks version 0.1.0', () => {
ensureNoDisposablesAreLeakedInTestSuite();
test('tasks: all default', () => {
const builder = new ConfigurationBuilder();
builder.task('tsc', 'tsc').
@@ -1497,6 +1500,8 @@ suite('Tasks version 0.1.0', () => {
});
suite('Tasks version 2.0.0', () => {
ensureNoDisposablesAreLeakedInTestSuite();
test.skip('Build workspace task', () => {
const external: IExternalTaskRunnerConfiguration = {
version: '2.0.0',
@@ -1677,6 +1682,8 @@ suite('Tasks version 2.0.0', () => {
});
suite('Bugs / regression tests', () => {
ensureNoDisposablesAreLeakedInTestSuite();
(Platform.isLinux ? test.skip : test)('Bug 19548', () => {
const external: IExternalTaskRunnerConfiguration = {
version: '0.1.0',
@@ -1784,6 +1791,8 @@ class TestTaskDefinitionRegistry implements Partial<ITaskDefinitionRegistry> {
}
suite('Task configuration conversions', () => {
ensureNoDisposablesAreLeakedInTestSuite();
const globals = {} as IGlobals;
const taskConfigSource = {} as TaskConfigSource;
const TaskDefinitionRegistry = new TestTaskDefinitionRegistry();