Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-15 07:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update usages of EditorOption.lineHeight (#261667)

Browse Source
This commit is contained in:
Bhavya U
2025-08-14 10:16:45 -07:00
committed by GitHub
parent 7d0d7ffd9b
commit 9604d612e5
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/vs/workbench/contrib/welcomeWalkthrough/browser/walkThroughPart.ts
View File

@@ -26,7 +26,7 @@ import { RawContextKey, IContextKey, IContextKeyService } from '../../../../plat
import { IConfigurationService } from '../../../../platform/configuration/common/configuration.js';
import { isObject } from '../../../../base/common/types.js';
import { CommandsRegistry } from '../../../../platform/commands/common/commands.js';
import { IEditorOptions as ICodeEditorOptions, EditorOption } from '../../../../editor/common/config/editorOptions.js';
import { EditorOption, IEditorOptions as ICodeEditorOptions } from '../../../../editor/common/config/editorOptions.js';
import { IThemeService } from '../../../../platform/theme/common/themeService.js';
import { UILabelProvider } from '../../../../base/common/keybindingLabels.js';
import { OS, OperatingSystem } from '../../../../base/common/platform.js';
@@ -326,7 +326,8 @@ export class WalkThroughPart extends EditorPane {
this.contentDisposables.push(editor);
const updateHeight = (initial: boolean) => {
const lineHeight = editor.getOption(EditorOption.lineHeight);
const position = editor.getPosition();
const lineHeight = position ? editor.getLineHeightForPosition(position) : editor.getOption(EditorOption.lineHeight);
const height = `${Math.max(model.getLineCount() + 1, 4) * lineHeight}px`;
if (div.style.height !== height) {
div.style.height = height;
@@ -343,7 +344,7 @@ export class WalkThroughPart extends EditorPane {
if (innerContent) {
const targetTop = div.getBoundingClientRect().top;
const containerTop = innerContent.getBoundingClientRect().top;
const lineHeight = editor.getOption(EditorOption.lineHeight);
const lineHeight = editor.getLineHeightForPosition(e.position);
const lineTop = (targetTop + (e.position.lineNumber - 1) * lineHeight) - containerTop;
const lineBottom = lineTop + lineHeight;
const scrollDimensions = this.scrollbar.getScrollDimensions();
@@ -495,3 +496,4 @@ export class WalkThroughPart extends EditorPane {
super.dispose();
}
}