Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-19 17:58:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce use of explicit any type (#274723)

Browse Source
This commit is contained in:
Benjamin Pasero
2025-11-30 08:37:08 +01:00
parent 8ccd1dae54
commit 99d307278f
9 changed files with 15 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
eslint.config.js
View File

@@ -600,15 +600,11 @@ export default tseslint.config(
'src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts',
'src/vs/workbench/contrib/accessibilitySignals/browser/commands.ts',
'src/vs/workbench/contrib/authentication/browser/actions/manageTrustedMcpServersForAccountAction.ts',
'src/vs/workbench/contrib/bulkEdit/browser/bulkCellEdits.ts',
'src/vs/workbench/contrib/bulkEdit/browser/bulkTextEdits.ts',
'src/vs/workbench/contrib/bulkEdit/browser/preview/bulkEditPane.ts',
'src/vs/workbench/contrib/bulkEdit/browser/preview/bulkEditPreview.ts',
'src/vs/workbench/contrib/chat/browser/actions/chatCodeblockActions.ts',
'src/vs/workbench/contrib/chat/browser/actions/chatContextActions.ts',
'src/vs/workbench/contrib/chat/browser/chatAttachmentWidgets.ts',
'src/vs/workbench/contrib/chat/browser/chatContentParts/chatConfirmationWidget.ts',
'src/vs/workbench/contrib/chat/browser/chatContentParts/chatMultiDiffContentPart.ts',
'src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingActions.ts',
'src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingEditorActions.ts',
'src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingServiceImpl.ts',
@@ -632,7 +628,6 @@ export default tseslint.config(
'src/vs/workbench/contrib/codeEditor/browser/outline/documentSymbolsOutline.ts',
'src/vs/workbench/contrib/codeEditor/electron-browser/selectionClipboard.ts',
'src/vs/workbench/contrib/commands/common/commands.contribution.ts',
'src/vs/workbench/contrib/comments/browser/commentsAccessibleView.ts',
'src/vs/workbench/contrib/comments/browser/commentsTreeViewer.ts',
'src/vs/workbench/contrib/comments/browser/commentsView.ts',
'src/vs/workbench/contrib/comments/browser/reactionsAction.ts',
@@ -675,7 +670,6 @@ export default tseslint.config(
'src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts',
'src/vs/workbench/contrib/inlineChat/browser/inlineChatStrategies.ts',
'src/vs/workbench/contrib/markdown/browser/markdownDocumentRenderer.ts',
'src/vs/workbench/contrib/markdown/browser/markdownSettingRenderer.ts',
'src/vs/workbench/contrib/markers/browser/markers.contribution.ts',
'src/vs/workbench/contrib/markers/browser/markersView.ts',
'src/vs/workbench/contrib/mergeEditor/browser/commands/commands.ts',
@@ -758,7 +752,6 @@ export default tseslint.config(
'src/vs/workbench/contrib/tasks/common/taskSystem.ts',
'src/vs/workbench/contrib/tasks/common/tasks.ts',
'src/vs/workbench/contrib/testing/common/storedValue.ts',
'src/vs/workbench/contrib/testing/common/testItemCollection.ts',
'src/vs/workbench/contrib/testing/test/browser/testObjectTree.ts',
'src/vs/workbench/contrib/typeHierarchy/browser/typeHierarchy.contribution.ts',
'src/vs/workbench/contrib/typeHierarchy/common/typeHierarchy.ts',
@@ -768,7 +761,6 @@ export default tseslint.config(
'src/vs/workbench/contrib/webviewPanel/browser/webviewEditor.ts',
'src/vs/workbench/contrib/webviewPanel/browser/webviewEditorInputSerializer.ts',
'src/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.ts',
'src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts',
'src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedService.ts',
'src/vs/workbench/contrib/welcomeWalkthrough/browser/walkThroughPart.ts',
'src/vs/workbench/services/authentication/common/authentication.ts',

2
src/vs/workbench/contrib/bulkEdit/browser/bulkCellEdits.ts
View File

@@ -19,7 +19,7 @@ import { IEditorService } from '../../../services/editor/common/editorService.js
export class ResourceNotebookCellEdit extends ResourceEdit implements IWorkspaceNotebookCellEdit {
static is(candidate: any): candidate is IWorkspaceNotebookCellEdit {
static is(candidate: unknown): candidate is IWorkspaceNotebookCellEdit {
if (candidate instanceof ResourceNotebookCellEdit) {
return true;
}

2
src/vs/workbench/contrib/chat/browser/chatAttachmentWidgets.ts
View File

@@ -1131,7 +1131,7 @@ function setResourceContext(accessor: ServicesAccessor, scopedContextKeyService:
return resourceContextKey;
}
function addBasicContextMenu(accessor: ServicesAccessor, widget: HTMLElement, scopedContextKeyService: IScopedContextKeyService, menuId: MenuId, arg: any, updateContextKeys?: () => Promise<void>): IDisposable {
function addBasicContextMenu(accessor: ServicesAccessor, widget: HTMLElement, scopedContextKeyService: IScopedContextKeyService, menuId: MenuId, arg: unknown, updateContextKeys?: () => Promise<void>): IDisposable {
const contextMenuService = accessor.get(IContextMenuService);
const menuService = accessor.get(IMenuService);

4
src/vs/workbench/contrib/chat/browser/chatContentParts/chatConfirmationWidget.ts
View File

@@ -46,7 +46,7 @@ export interface IChatConfirmationWidgetOptions<T> {
message: string | IMarkdownString;
subtitle?: string | IMarkdownString;
buttons: IChatConfirmationButton<T>[];
toolbarData?: { arg: any; partType: string; partSource?: string };
toolbarData?: { arg: unknown; partType: string; partSource?: string };
silent?: boolean;
}
@@ -330,7 +330,7 @@ export interface IChatConfirmationWidget2Options<T> {
icon?: ThemeIcon;
subtitle?: string | IMarkdownString;
buttons: IChatConfirmationButton<T>[];
toolbarData?: { arg: any; partType: string; partSource?: string };
toolbarData?: { arg: unknown; partType: string; partSource?: string };
}
abstract class BaseChatConfirmationWidget<T> extends Disposable {

2
src/vs/workbench/contrib/chat/browser/chatContentParts/chatMultiDiffContentPart.ts
View File

@@ -136,7 +136,7 @@ export class ChatMultiDiffContentPart extends Disposable implements IChatContent
const setupActionBar = () => {
actionBar.clear();
let marshalledUri: any | undefined = undefined;
let marshalledUri: unknown | undefined = undefined;
let contextKeyService: IContextKeyService = this.contextKeyService;
if (this.editorService.activeEditor instanceof ChatEditorInput) {
contextKeyService = this.contextKeyService.createOverlay([

3
src/vs/workbench/contrib/comments/browser/commentsAccessibleView.ts
View File

@@ -15,6 +15,7 @@ import { COMMENTS_VIEW_ID, CommentsMenus } from './commentsTreeViewer.js';
import { CommentsPanel, CONTEXT_KEY_COMMENT_FOCUSED } from './commentsView.js';
import { IViewsService } from '../../../services/views/common/viewsService.js';
import { ICommentService } from './commentService.js';
import { CommentNode } from '../common/commentModel.js';
import { CommentContextKeys } from '../common/commentContextKeys.js';
import { moveToNextCommentInThread as findNextCommentInThread, revealCommentThread } from './commentsController.js';
import { IEditorService } from '../../../services/editor/common/editorService.js';
@@ -76,7 +77,7 @@ class CommentsAccessibleContentProvider extends Disposable implements IAccessibl
public readonly actions: IAction[];
constructor(
private readonly _commentsView: CommentsPanel,
private readonly _focusedCommentNode: any,
private readonly _focusedCommentNode: CommentNode,
private readonly _menus: CommentsMenus,
) {
super();

8
src/vs/workbench/contrib/markdown/browser/markdownSettingRenderer.ts
View File

@@ -20,9 +20,9 @@ export class SimpleSettingRenderer {
private readonly codeSettingAnchorRegex: RegExp;
private readonly codeSettingSimpleRegex: RegExp;
private _updatedSettings = new Map<string, any>(); // setting ID to user's original setting value
private _updatedSettings = new Map<string, unknown>(); // setting ID to user's original setting value
private _encounteredSettings = new Map<string, ISetting>(); // setting ID to setting
private _featuredSettings = new Map<string, any>(); // setting ID to feature value
private _featuredSettings = new Map<string, unknown>(); // setting ID to feature value
constructor(
@IConfigurationService private readonly _configurationService: IConfigurationService,
@@ -87,7 +87,7 @@ export class SimpleSettingRenderer {
};
}
settingToUriString(settingId: string, value?: any): string {
settingToUriString(settingId: string, value?: unknown): string {
return `${Schemas.codeSetting}://${settingId}${value ? `/${value}` : ''}`;
}
@@ -208,7 +208,7 @@ export class SimpleSettingRenderer {
return this._configurationService.updateValue(settingId, userOriginalSettingValue, ConfigurationTarget.USER);
}
async setSetting(settingId: string, currentSettingValue: any, newSettingValue: any): Promise<void> {
async setSetting(settingId: string, currentSettingValue: unknown, newSettingValue: unknown): Promise<void> {
this._updatedSettings.set(settingId, currentSettingValue);
return this._configurationService.updateValue(settingId, newSettingValue, ConfigurationTarget.USER);
}

2
src/vs/workbench/contrib/testing/common/testItemCollection.ts
View File

@@ -129,7 +129,7 @@ const diffableProps: { [K in keyof ITestItem]?: (a: ITestItem[K], b: ITestItem[K
},
};
const diffableEntries = Object.entries(diffableProps) as readonly [keyof ITestItem, (a: any, b: any) => boolean][];
const diffableEntries = Object.entries(diffableProps) as readonly [keyof ITestItem, (a: unknown, b: unknown) => boolean][];
const diffTestItems = (a: ITestItem, b: ITestItem) => {
let output: Record<string, unknown> | undefined;

6
src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts
View File

@@ -1319,7 +1319,7 @@ export class GettingStartedPage extends EditorPane {
const commandURI = URI.parse(command);
// execute as command
let args: any = [];
let args = [];
try {
args = parse(decodeURIComponent(commandURI.query));
} catch {
@@ -1355,8 +1355,8 @@ export class GettingStartedPage extends EditorPane {
}
}
this.commandService.executeCommand<any>(commandURI.path, ...args).then(result => {
const toOpen: URI = result?.openFolder;
this.commandService.executeCommand(commandURI.path, ...args).then(result => {
const toOpen = (result as { openFolder?: URI })?.openFolder;
if (toOpen) {
if (!URI.isUri(toOpen)) {
console.warn('Warn: Running walkthrough command', href, 'yielded non-URI `openFolder` result', toOpen, '. It will be disregarded.');