Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 02:58:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean up profile provider api

Browse Source
This commit is contained in:
Daniel Imms
2021-05-27 15:27:38 -07:00
parent e8758933d8
commit 9b609ab1e1
4 changed files with 3 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/vs/workbench/api/common/extHostTerminalService.ts
View File

@@ -585,7 +585,6 @@ export abstract class BaseExtHostTerminalService extends Disposable implements I
}
public registerProfileProvider(id: string, provider: vscode.TerminalProfileProvider): vscode.Disposable {
console.log('registerProfileProvider', id);
if (this._profileProviders.has(id)) {
throw new Error(`Terminal profile provider "${id}" already registered`);
}
@@ -607,12 +606,8 @@ export abstract class BaseExtHostTerminalService extends Disposable implements I
throw new Error(`No terminal profile options provided for id "${id}"`);
}
if ('pty' in options) {
// TODO: Pass in split terminal option
this.createExtensionTerminal(options, { isSplitTerminal });
}
// if (options.iconPath) {
// checkProposedApiEnabled(extension);
// }
this.createTerminalFromOptions(options, { isSplitTerminal });
}