Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 20:26:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid unnecessary workspace edits (#207377)

Browse Source
This commit is contained in:
Don Jayamanne
2024-03-12 12:03:43 +11:00
committed by GitHub
parent ac31a0ccdd
commit 9c3cc8b994
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/ipynb/src/notebookAttachmentCleaner.ts
View File

@@ -103,7 +103,9 @@ export class AttachmentCleaner implements vscode.CodeActionProvider {
notebookEdits.push(metadataEdit);
}
}
if (!notebookEdits.length) {
return;
}
const workspaceEdit = new vscode.WorkspaceEdit();
workspaceEdit.set(e.notebook.uri, notebookEdits);
@@ -229,7 +231,7 @@ export class AttachmentCleaner implements vscode.CodeActionProvider {
this.updateDiagnostics(cell.document.uri, diagnostics);
if (cell.index > -1 && !objectEquals(markdownAttachmentsInUse, cell.metadata.attachments)) {
if (cell.index > -1 && !objectEquals(markdownAttachmentsInUse || {}, cell.metadata.attachments || {})) {
const updateMetadata: { [key: string]: any } = deepClone(cell.metadata);
if (Object.keys(markdownAttachmentsInUse).length === 0) {
updateMetadata.attachments = undefined;