Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-17 15:24:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix double shimmer when chat is getting ready and fix tool call icons (#298083)

Browse Source 
* fix double shimmer when chat is getting ready

* fix padding

* fix double spinner

* remove list renderer changes
This commit is contained in:
Justin Chen
2026-02-26 18:17:45 -08:00
committed by GitHub
parent a042a1cef0
commit 9ceb219f2e
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatProgressContentPart.ts
View File

@@ -67,7 +67,8 @@ export class ChatProgressContentPart extends Disposable implements IChatContentP
alert(progress.content.value);
}
const isLoadingIcon = icon && ThemeIcon.isEqual(icon, ThemeIcon.modify(Codicon.loading, 'spin'));
const useShimmer = shimmer ?? ((!icon || isLoadingIcon) && this.showSpinner);
// Even if callers request shimmer, only the active (spinner-visible) progress row should animate.
const useShimmer = (shimmer ?? (!icon || isLoadingIcon)) && this.showSpinner;
// if we have shimmer, don't show spinner
const codicon = useShimmer ? Codicon.check : (icon ?? (this.showSpinner ? ThemeIcon.modify(Codicon.loading, 'spin') : Codicon.check));
const result = this.chatContentMarkdownRenderer.render(progress.content);

3
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts
View File

@@ -66,7 +66,8 @@ export function getToolInvocationIcon(toolId: string): ThemeIcon {
if (
lowerToolId.includes('edit') ||
lowerToolId.includes('create')
lowerToolId.includes('create') ||
lowerToolId.includes('replace')
) {
return Codicon.pencil;
}

2
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatThinkingContent.css
View File

@@ -184,7 +184,7 @@
}
.chat-thinking-tool-wrapper .chat-markdown-part.rendered-markdown {
padding: 5px 12px 4px 20px;
padding: 5px 12px 4px 24px;
.status-icon.codicon-check {
display: none;