Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 17:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Listen to right event in rectangle renderer

Browse Source 
Fixes #233933
This commit is contained in:
Daniel Imms
2024-11-15 09:49:25 -08:00
parent 2fc01434d6
commit 9fc7493f47
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/editor/browser/gpu/rectangleRenderer.ts
+1 -5
View File
@@ -8,7 +8,7 @@ import { Event } from '../../../base/common/event.js';
import { IReference, MutableDisposable } from '../../../base/common/lifecycle.js';
import { EditorOption } from '../../common/config/editorOptions.js';
import { ViewEventHandler } from '../../common/viewEventHandler.js';
import type { ViewCursorStateChangedEvent, ViewScrollChangedEvent } from '../../common/viewEvents.js';
import type { ViewScrollChangedEvent } from '../../common/viewEvents.js';
import type { ViewportData } from '../../common/viewLayout/viewLinesViewportData.js';
import type { ViewContext } from '../../common/viewModel/viewContext.js';
import { GPULifecycle } from './gpuDisposable.js';
@@ -244,10 +244,6 @@ export class RectangleRenderer extends ViewEventHandler {
// #region Event handlers
public override onScrollChanged(e: ViewScrollChangedEvent): boolean {
return true;
}
public override onCursorStateChanged(e: ViewCursorStateChangedEvent): boolean {
if (this._device) {
const dpr = getActiveWindow().devicePixelRatio;
this._scrollOffsetValueBuffer[0] = this._context.viewLayout.getCurrentScrollLeft() * dpr;
src/vs/editor/browser/viewParts/rulersGpu/rulersGpu.ts
+3 -3
View File
@@ -10,7 +10,7 @@ import * as viewEvents from '../../../common/viewEvents.js';
import { EditorOption } from '../../../common/config/editorOptions.js';
import type { ViewGpuContext } from '../../gpu/viewGpuContext.js';
import type { IObjectCollectionBufferEntry } from '../../gpu/objectCollectionBuffer.js';
import type { RectangleRendererEntrySpec } from '../../gpu/rectangleRenderer.js';
import type { RectangleRenderer, RectangleRendererEntrySpec } from '../../gpu/rectangleRenderer.js';
import { Color } from '../../../../base/common/color.js';
import { editorRuler } from '../../../common/core/editorColorRegistry.js';
import { autorun, type IReader } from '../../../../base/common/observable.js';
@@ -57,7 +57,7 @@ export class RulersGpu extends ViewPart {
const ruler = rulers[i];
const shape = this._gpuShapes[i];
const color = ruler.color ? Color.fromHex(ruler.color) : this._context.theme.getColor(editorRuler) ?? Color.white;
const rulerData = [
const rulerData: Parameters<RectangleRenderer['register']> = [
ruler.column * typicalHalfwidthCharacterWidth * devicePixelRatio,
0,
Math.max(1, Math.ceil(devicePixelRatio)),
@@ -66,7 +66,7 @@ export class RulersGpu extends ViewPart {
color.rgba.g / 255,
color.rgba.b / 255,
color.rgba.a,
] as const;
];
if (!shape) {
this._gpuShapes[i] = this._viewGpuContext.rectangleRenderer.register(...rulerData);
} else {