Quick search: Not possible to search for space in front (#201015)

Fixes #192765
This commit is contained in:
Andrea Mah
2023-12-15 13:18:59 -08:00
committed by GitHub
parent ac66410966
commit a10b7ff583
2 changed files with 10 additions and 2 deletions
@@ -70,6 +70,9 @@ export interface IPickerQuickAccessProviderOptions<T extends IPickerQuickAccessI
* Enables to show a pick entry when no results are returned from a search.
*/
readonly noResultsPick?: T | ((filter: string) => T);
/** Whether to skip trimming the pick filter string */
readonly shouldSkipTrimPickFilter?: boolean;
}
export type Pick<T> = T | IQuickPickSeparator;
@@ -138,7 +141,12 @@ export abstract class PickerQuickAccessProvider<T extends IPickerQuickAccessItem
// Collect picks and support both long running and short or combined
const picksToken = picksCts.token;
const picksFilter = picker.value.substr(this.prefix.length).trim();
let picksFilter = picker.value.substring(this.prefix.length);
if (!this.options?.shouldSkipTrimPickFilter) {
picksFilter = picksFilter.trim();
}
const providedPicks = this._getPicks(picksFilter, picksDisposables, picksToken, runOptions);
const applyPicks = (picks: Picks<T>, skipEmpty?: boolean): boolean => {
@@ -70,7 +70,7 @@ export class TextSearchQuickAccess extends PickerQuickAccessProvider<IPickerQuic
@IViewsService private readonly _viewsService: IViewsService,
@IConfigurationService private readonly _configurationService: IConfigurationService,
) {
super(TEXT_SEARCH_QUICK_ACCESS_PREFIX, { canAcceptInBackground: true });
super(TEXT_SEARCH_QUICK_ACCESS_PREFIX, { canAcceptInBackground: true, shouldSkipTrimPickFilter: true });
this.queryBuilder = this._instantiationService.createInstance(QueryBuilder);
this.searchModel = this._instantiationService.createInstance(SearchModel);