Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-08 15:55:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Hide models contributed by background agents (#295669)

Browse Source 
* Hide models contributed by background agents

* Updates

* Add additioknal tests
This commit is contained in:
Don Jayamanne
2026-02-17 20:34:36 +11:00
committed by GitHub
parent 44724dcea7
commit aae3af1c04
4 changed files with 47 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
+2 -1
View File
@@ -2172,7 +2172,8 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
this.setCurrentLanguageModel(model);
this.renderAttachedContext();
},
getModels: () => this.getModels()
getModels: () => this.getModels(),
canManageModels: () => !this.getCurrentSessionType()
};
return this.modelWidget = this.instantiationService.createInstance(ModelPickerActionItem, action, undefined, itemDelegate, pickerOptions);
} else if (action.id === OpenModePickerAction.ID && action instanceof MenuItemAction) {
src/vs/workbench/contrib/chat/browser/widget/input/modelPickerActionItem.ts
+3 -1
View File
@@ -29,6 +29,7 @@ export interface IModelPickerDelegate {
readonly currentModel: IObservable<ILanguageModelChatMetadataAndIdentifier | undefined>;
setModel(model: ILanguageModelChatMetadataAndIdentifier): void;
getModels(): ILanguageModelChatMetadataAndIdentifier[];
canManageModels(): boolean;
}
type ChatModelChangeClassification = {
@@ -165,9 +166,10 @@ export class ModelPickerActionItem extends ChatInputPickerActionViewItem {
run: () => { }
};
const baseActionBarActionProvider = getModelPickerActionBarActionProvider(commandService, chatEntitlementService, productService);
const modelPickerActionWidgetOptions: Omit<IActionWidgetDropdownOptions, 'label' | 'labelRenderer'> = {
actionProvider: modelDelegateToWidgetActionsProvider(delegate, telemetryService, pickerOptions),
actionBarActionProvider: getModelPickerActionBarActionProvider(commandService, chatEntitlementService, productService),
actionBarActionProvider: { getActions: () => delegate.canManageModels() ? baseActionBarActionProvider.getActions() : [] },
reporter: { id: 'ChatModelPicker', name: 'ChatModelPicker', includeOptions: true },
};
src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptHeaderAutocompletion.ts
+1 -1
View File
@@ -317,7 +317,7 @@ export class PromptHeaderAutocompletion implements CompletionItemProvider {
const result = [];
for (const model of this.languageModelsService.getLanguageModelIds()) {
const metadata = this.languageModelsService.lookupLanguageModel(model);
if (metadata && metadata.isUserSelectable !== false) {
if (metadata && metadata.isUserSelectable !== false && !metadata.targetChatSessionType) {
if (!agentModeOnly || ILanguageModelChatMetadata.suitableForAgentMode(metadata)) {
result.push({
name: ILanguageModelChatMetadata.asQualifiedName(metadata),
src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptHeaderAutocompletion.test.ts
+41
View File
@@ -56,6 +56,7 @@ suite('PromptHeaderAutocompletion', () => {
{ id: 'mae-4', name: 'MAE 4', vendor: 'olama', version: '1.0', family: 'mae', modelPickerCategory: undefined, extension: new ExtensionIdentifier('a.b'), isUserSelectable: true, maxInputTokens: 8192, maxOutputTokens: 1024, capabilities: { agentMode: true, toolCalling: true }, isDefaultForLocation: { [ChatAgentLocation.Chat]: true } } satisfies ILanguageModelChatMetadata,
{ id: 'mae-4.1', name: 'MAE 4.1', vendor: 'copilot', version: '1.0', family: 'mae', modelPickerCategory: undefined, extension: new ExtensionIdentifier('a.b'), isUserSelectable: true, maxInputTokens: 8192, maxOutputTokens: 1024, capabilities: { agentMode: true, toolCalling: true }, isDefaultForLocation: { [ChatAgentLocation.Chat]: true } } satisfies ILanguageModelChatMetadata,
{ id: 'gpt-4', name: 'GPT 4', vendor: 'openai', version: '1.0', family: 'gpt', modelPickerCategory: undefined, extension: new ExtensionIdentifier('a.b'), isUserSelectable: true, maxInputTokens: 8192, maxOutputTokens: 1024, capabilities: { agentMode: false, toolCalling: true }, isDefaultForLocation: { [ChatAgentLocation.Chat]: true } } satisfies ILanguageModelChatMetadata,
{ id: 'bg-agent-model', name: 'BG Agent Model', vendor: 'copilot', version: '1.0', family: 'bg', modelPickerCategory: undefined, extension: new ExtensionIdentifier('a.b'), isUserSelectable: true, maxInputTokens: 8192, maxOutputTokens: 1024, capabilities: { agentMode: true, toolCalling: true }, isDefaultForLocation: { [ChatAgentLocation.Chat]: true }, targetChatSessionType: 'background' } satisfies ILanguageModelChatMetadata,
];
instaService.stub(ILanguageModelsService, {
@@ -361,6 +362,33 @@ suite('PromptHeaderAutocompletion', () => {
{ label: 'true', result: 'disable-model-invocation: true' },
].sort(sortByLabel));
});
test('exclude models with targetChatSessionType from agent model completions', async () => {
const content = [
'---',
'description: "Test"',
'model: |',
'---',
].join('\n');
const actual = await getCompletions(content, PromptsType.agent);
const labels = actual.map(a => a.label);
// BG Agent Model has targetChatSessionType set, so it should be excluded
assert.ok(!labels.includes('BG Agent Model (copilot)'), 'Models with targetChatSessionType should be excluded from agent model completions');
});
test('exclude models with targetChatSessionType from agent model array completions', async () => {
const content = [
'---',
'description: "Test"',
'model: [|]',
'---',
].join('\n');
const actual = await getCompletions(content, PromptsType.agent);
const labels = actual.map(a => a.label);
assert.ok(!labels.includes('BG Agent Model (copilot)'), 'Models with targetChatSessionType should be excluded from agent model array completions');
});
});
suite('claude agent header completions', () => {
@@ -546,5 +574,18 @@ suite('PromptHeaderAutocompletion', () => {
{ label: 'GPT 4 (openai)', result: 'model: GPT 4 (openai)' },
].sort(sortByLabel));
});
test('exclude models with targetChatSessionType from prompt model completions', async () => {
const content = [
'---',
'description: "Test"',
'model: |',
'---',
].join('\n');
const actual = await getCompletions(content, PromptsType.prompt);
const labels = actual.map(a => a.label);
assert.ok(!labels.includes('BG Agent Model (copilot)'), 'Models with targetChatSessionType should be excluded from prompt model completions');
});
});
});