Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-02 00:09:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #303596 from microsoft/isidorn/attractive-goldfish

Browse Source 
fixes #303425
This commit is contained in:
Isidor Nikolic
2026-03-20 21:13:13 +01:00
committed by GitHub
parent 69ca0c3f58 1d47f2365b
commit b266620dc6
2 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts
View File

@@ -720,10 +720,6 @@ export class RunInTerminalTool extends Disposable implements IToolImpl {
}
if (requiresUnsandboxConfirmation) {
disclaimer = new MarkdownString([
disclaimer?.value,
localize('runInTerminal.unsandboxed.disclaimer', "$(warning) This command will run outside the terminal sandbox and may access files, network resources, or system state that sandboxed commands cannot reach.")
].filter(Boolean).join(' '), { supportThemeIcons: true, isTrusted: disclaimer?.isTrusted });
confirmationTitle = args.isBackground
? localize('runInTerminal.unsandboxed.background', "Run `{0}` command outside the sandbox in background?", shellType)
: localize('runInTerminal.unsandboxed', "Run `{0}` command outside the sandbox?", shellType);

7
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts
View File

@@ -480,12 +480,7 @@ suite('RunInTerminalTool', () => {
}
ok(confirmationMessage.value.includes('Reason for leaving the sandbox: Needs network access outside the sandbox'));
const disclaimer = result?.confirmationMessages?.disclaimer;
ok(disclaimer && typeof disclaimer !== 'string');
if (!disclaimer || typeof disclaimer === 'string') {
throw new Error('Expected markdown disclaimer');
}
ok(disclaimer.value.includes('outside the terminal sandbox'));
strictEqual(result?.confirmationMessages?.disclaimer, undefined);
strictEqual(result?.confirmationMessages?.terminalCustomActions, undefined);
});
});