Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-15 07:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #274929 from mjbvz/dev/mjbvz/intense-catshark

Browse Source 
Avoid extra `toDisposable` call
This commit is contained in:
Matt Bierner
2025-11-03 16:32:04 -08:00
committed by GitHub
parent b01211dec2 1641855e75
commit b60ec5d8a8
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/vs/platform/hover/browser/hoverWidget.ts
View File

@@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/
import './hover.css';
import { DisposableStore, MutableDisposable, toDisposable } from '../../../base/common/lifecycle.js';
import { DisposableStore, MutableDisposable } from '../../../base/common/lifecycle.js';
import { Event, Emitter } from '../../../base/common/event.js';
import * as dom from '../../../base/browser/dom.js';
import { IKeybindingService } from '../../keybinding/common/keybinding.js';
@@ -177,7 +177,7 @@ export class HoverWidget extends Widget implements IHoverWidget {
} else {
const markdown = options.content;
const { element, dispose } = this._markdownRenderer.render(markdown, {
const { element } = this._register(this._markdownRenderer.render(markdown, {
actionHandler: this._linkHandler,
asyncRenderCallback: () => {
contentsElement.classList.add('code-hover-contents');
@@ -185,9 +185,8 @@ export class HoverWidget extends Widget implements IHoverWidget {
// This changes the dimensions of the hover so trigger a layout
this._onRequestLayout.fire();
}
});
}));
contentsElement.appendChild(element);
this._register(toDisposable(dispose));
}
rowElement.appendChild(contentsElement);
this._hover.contentsDomNode.appendChild(rowElement);