Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-03-02 06:35:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: memory leak in chat welcome (#271121)

Browse Source
This commit is contained in:
Simon Siefke
2025-10-13 18:42:07 +03:00
committed by GitHub
parent 7e18f586ad
commit bb0294ffca
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/workbench/contrib/chat/browser/chatWidget.ts
View File

@@ -314,6 +314,8 @@ export class ChatWidget extends Disposable implements IChatWidget {
private welcomeMessageContainer!: HTMLElement;
private readonly welcomePart: MutableDisposable<ChatViewWelcomePart> = this._register(new MutableDisposable());
private readonly welcomeContextMenuDisposable: MutableDisposable<IDisposable> = this._register(new MutableDisposable());
private readonly historyViewStore = this._register(new DisposableStore());
private readonly chatTodoListWidget: ChatTodoListWidget;
private historyList: WorkbenchList<IChatHistoryListItem> | undefined;
@@ -1066,7 +1068,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
dom.append(this.welcomeMessageContainer, this.welcomePart.value.element);
// Add right-click context menu to the entire welcome container
this._register(dom.addDisposableListener(this.welcomeMessageContainer, dom.EventType.CONTEXT_MENU, (e) => {
this.welcomeContextMenuDisposable.value = dom.addDisposableListener(this.welcomeMessageContainer, dom.EventType.CONTEXT_MENU, (e) => {
e.preventDefault();
e.stopPropagation();
this.contextMenuService.showContextMenu({
@@ -1078,7 +1080,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
getAnchor: () => ({ x: e.clientX, y: e.clientY }),
getActionsContext: () => ({})
});
}));
});
}
}