Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-18 06:09:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #316049 from CodeEditorLand/fix-protected-override-1

Browse Source 
fix: restore protected modifier on relayCreationTimeoutMs in test helper
This commit is contained in:
Connor Peet
2026-05-13 10:01:54 -07:00
committed by GitHub
parent 5060335843 c5061c3b6a
commit bb200f48bb
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/platform/agentHost/test/node/sshRemoteAgentHostService.test.ts
+7 -2
View File
@@ -174,7 +174,7 @@ class TestableSSHRemoteAgentHostMainService extends SSHRemoteAgentHostMainServic
hangRelayCreationOnCall: number | undefined;
/** Public override so tests can shorten the relay creation timeout. */
override relayCreationTimeoutMs: number = 30_000;
protected override relayCreationTimeoutMs: number = 30_000;
/** Stored onMessage callbacks from relays, most recent last. */
private readonly _relayMessageCallbacks: Array<(data: string) => void> = [];
@@ -279,6 +279,11 @@ class TestableSSHRemoteAgentHostMainService extends SSHRemoteAgentHostMainServic
this._relayCloseCallbacks[this._relayCloseCallbacks.length - 1]();
}
}
/** Sets the relay creation timeout; exposed for tests only. */
setRelayCreationTimeoutForTest(ms: number): void {
this.relayCreationTimeoutMs = ms;
}
}
suite('SSHRemoteAgentHostMainService - connect flow', () => {
@@ -1017,7 +1022,7 @@ suite('SSHRemoteAgentHostMainService - connect flow', () => {
assert.strictEqual(originalClient.ended, false);
// Use a short timeout so the test completes quickly.
service.relayCreationTimeoutMs = 50;
service.setRelayCreationTimeoutForTest(50);
// Make the *reconnect* call's relay creation hang (the second relay).
service.hangRelayCreationOnCall = 2;