Revert "Improve logging"

This reverts commit 4bba4f2554.
This commit is contained in:
Matt Bierner
2021-10-14 17:02:58 -07:00
parent 33d6815ac3
commit bc76074ada
4 changed files with 9 additions and 10 deletions
@@ -621,8 +621,8 @@ export abstract class AbstractExtHostExtensionService extends Disposable impleme
}
public async $extensionTestsExit(code: number): Promise<void> {
this._logService.info(`Extension host terminating: test runner requested exit with code ${code}`);
this._logService.info(`Extension host with pid ${process.pid} exiting with code ${code}`);
this._logService.info(`extension host terminating: test runner requested exit with code ${code}`);
this._logService.info(`exiting with code ${code}`);
this._logService.flush();
this._hostUtils.exit(code);
}
@@ -638,7 +638,7 @@ export abstract class AbstractExtHostExtensionService extends Disposable impleme
.then(() => this._handleEagerExtensions())
.then(() => {
this._eagerExtensionsActivated.open();
this._logService.info(`Eager extensions activated`);
this._logService.info(`eager extensions activated`);
});
}
@@ -94,7 +94,7 @@ export class ExtHostExtensionService extends AbstractExtHostExtensionService {
}
let r: T | null = null;
activationTimesBuilder.codeLoadingStart();
this._logService.trace(`ExtensionService#loadCommonJSModule ${module.toString(true)}`);
this._logService.info(`ExtensionService#loadCommonJSModule ${module.toString(true)}`);
this._logService.flush();
try {
if (extensionId) {
@@ -70,7 +70,7 @@ export class ExtensionHostMain {
this._logService = instaService.invokeFunction(accessor => accessor.get(ILogService));
performance.mark(`code/extHost/didCreateServices`);
this._logService.info(`Extension host with pid ${process.pid} started`);
this._logService.info('extension host started');
this._logService.trace('initData', initData);
// ugly self - inject
@@ -136,7 +136,7 @@ export class ExtensionHostMain {
// Give extensions 1 second to wrap up any async dispose, then exit in at most 4 seconds
setTimeout(() => {
Promise.race([timeout(4000), extensionsDeactivated]).finally(() => {
this._logService.info(`Extension host with pid ${process.pid} exiting with code 0`);
this._logService.info(`exiting with code 0`);
this._logService.flush();
this._logService.dispose();
this._hostUtils.exit(0);
@@ -102,8 +102,7 @@ class ExtensionHostManager extends Disposable implements IExtensionHostManager {
initialActivationEvents: string[],
@IInstantiationService private readonly _instantiationService: IInstantiationService,
@IWorkbenchEnvironmentService private readonly _environmentService: IWorkbenchEnvironmentService,
@ITelemetryService private readonly _telemetryService: ITelemetryService,
@ILogService private readonly _logService: ILogService,
@ITelemetryService private readonly _telemetryService: ITelemetryService
) {
super();
this._cachedActivationEvents = new Map<string, Promise<void>>();
@@ -136,8 +135,8 @@ class ExtensionHostManager extends Disposable implements IExtensionHostManager {
return { value: this._createExtensionHostCustomers(protocol) };
},
(err) => {
this._logService.error(`Error received from starting extension host (kind: ${extensionHostKindToString(this.kind)})`);
this._logService.error(err);
console.error(`Error received from starting extension host (kind: ${extensionHostKindToString(this.kind)})`);
console.error(err);
// Track errors during extension host startup
const failureTelemetryEvent: ExtensionHostStartupEvent = {