Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-27 19:08:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Simplify terminal onData listeners

Browse Source
This commit is contained in:
Daniel Imms
2018-06-12 16:53:46 +02:00
parent b0e2d1d0cd
commit bd5ee49f88
1 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts
+1 -18
View File
@@ -65,7 +65,6 @@ export class TerminalInstance implements ITerminalInstance {
private _rows: number;
private _windowsShellHelper: WindowsShellHelper;
private _onLineDataListeners: ((lineData: string) => void)[];
private _onDataListeners: ((data: string) => void)[];
private _xtermReadyPromise: TPromise<void>;
private _disposables: lifecycle.IDisposable[];
@@ -120,7 +119,6 @@ export class TerminalInstance implements ITerminalInstance {
this._disposables = [];
this._skipTerminalCommands = [];
this._onLineDataListeners = [];
this._onDataListeners = [];
this._isExiting = false;
this._hadFocusOnExit = false;
this._isVisible = false;
@@ -686,13 +684,6 @@ export class TerminalInstance implements ITerminalInstance {
if (this._xterm) {
this._xterm.write(data);
}
this._onDataListeners.forEach(listener => {
try {
listener(data);
} catch (err) {
console.error(`onData listener threw`, err);
}
});
}
private _onProcessExit(exitCode: number): void {
@@ -799,15 +790,7 @@ export class TerminalInstance implements ITerminalInstance {
}
public onData(listener: (data: string) => void): lifecycle.IDisposable {
this._onDataListeners.push(listener);
return {
dispose: () => {
const i = this._onDataListeners.indexOf(listener);
if (i >= 0) {
this._onDataListeners.splice(i, 1);
}
}
};
return this._processManager.onProcessData(data => listener(data));
}
public onLineData(listener: (lineData: string) => void): lifecycle.IDisposable {