Finalize idToken API (#274464)

Fixes https://github.com/microsoft/vscode/issues/140929

extensions/microsoft-authentication/package.json

@@ -14,7 +14,6 @@
   ],
   "activationEvents": [],
   "enabledApiProposals": [
-    "idToken",
     "nativeWindowHandle",
     "authIssuers",
     "authenticationChallenges"

extensions/microsoft-authentication/tsconfig.json

@@ -12,7 +12,6 @@
 	"include": [
 		"src/**/*",
 		"../../src/vscode-dts/vscode.d.ts",
-		"../../src/vscode-dts/vscode.proposed.idToken.d.ts",
 		"../../src/vscode-dts/vscode.proposed.nativeWindowHandle.d.ts",
 		"../../src/vscode-dts/vscode.proposed.authIssuers.d.ts",
 		"../../src/vscode-dts/vscode.proposed.authenticationChallenges.d.ts"

src/vs/platform/extensions/common/extensionsApiProposals.ts

@@ -240,9 +240,6 @@ const _allApiProposals = {
 	fsChunks: {
 		proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.fsChunks.d.ts',
 	},
-	idToken: {
-		proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.idToken.d.ts',
-	},
 	inlineCompletionsAdditions: {
 		proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.inlineCompletionsAdditions.d.ts',
 	},

src/vscode-dts/vscode.d.ts

@@ -17969,10 +17969,17 @@ declare module 'vscode' {
 		readonly id: string;
 
 		/**
-		 * The access token.
+		 * The access token. This token should be used to authenticate requests to a service. Popularized by OAuth.
+		 * @reference https://oauth.net/2/access-tokens/
 		 */
 		readonly accessToken: string;
 
+		/**
+		 * The ID token. This token contains identity information about the user. Popularized by OpenID Connect.
+		 * @reference https://openid.net/specs/openid-connect-core-1_0.html#IDToken
+		 */
+		readonly idToken?: string;
+
 		/**
 		 * The account associated with the session.
 		 */

src/vscode-dts/vscode.proposed.idToken.d.ts

@@ -1,16 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-declare module 'vscode' {
-	/**
-	 * Represents a session of a currently logged in user.
-	 */
-	export interface AuthenticationSession {
-		/**
-		 * An optional ID token that may be included in the session.
-		 */
-		readonly idToken?: string;
-	}
-}