Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 20:26:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Button - Use single loop to set button content (#160933)

Browse Source 
Use single loop to set button content
This commit is contained in:
Ladislau Szomoru
2022-09-15 13:44:34 +02:00
committed by GitHub
parent 8775cd3e25
commit c1d7ca8bac
1 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/vs/base/browser/ui/button/button.ts
View File

@@ -198,21 +198,24 @@ export class Button extends Disposable implements IButton {
set label(value: string) {
this._element.classList.add('monaco-text-button');
if (this.options.supportIcons) {
// Remove empty segments
const segments = renderLabelWithIcons(value)
.filter(segment => {
return (typeof (segment) === 'string' && segment.trim() === '') ? false : true;
});
// Convert string segments to <span> nodes
const content = segments.map(segment => {
const content: HTMLSpanElement[] = [];
for (let segment of renderLabelWithIcons(value)) {
if (typeof (segment) === 'string') {
segment = segment.trim();
// Ignore empty segment
if (segment === '') {
continue;
}
// Convert string segments to <span> nodes
const node = document.createElement('span');
node.textContent = segment.trim();
return node;
node.textContent = segment;
content.push(node);
} else {
content.push(segment);
}
return segment;
});
}
reset(this._element, ...content);
} else {