Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-13 15:35:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use for now alerts for suggestion items

Browse Source
This commit is contained in:
Alex Dima
2016-03-09 16:58:24 +01:00
parent a730ee9d9a
commit c6482c7e8d
1 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/editor/contrib/suggest/browser/suggestWidget.ts
+30 -5
View File
@@ -329,6 +329,20 @@ export class SuggestWidget implements IContentWidget, IDisposable {
this.onModelModeChanged();
this.editor.addContentWidget(this);
this.setState(State.Hidden);
// TODO@Alex: this is useful, but spammy
// var isVisible = false;
// this.onDidVisibilityChange((newIsVisible) => {
// if (isVisible === newIsVisible) {
// return;
// }
// isVisible = newIsVisible;
// if (isVisible) {
// alert(nls.localize('suggestWidgetAriaVisible', "Suggestions opened"));
// } else {
// alert(nls.localize('suggestWidgetAriaInvisible', "Suggestions closed"));
// }
// });
}
private onCursorSelectionChanged(): void {
@@ -370,6 +384,7 @@ export class SuggestWidget implements IContentWidget, IDisposable {
}, 0);
}
private _lastSuggestionLabel: string;
private onListFocus(e: IFocusChangeEvent<CompletionItem>): void {
if (this.currentSuggestionDetails) {
this.currentSuggestionDetails.cancel();
@@ -377,15 +392,25 @@ export class SuggestWidget implements IContentWidget, IDisposable {
}
if (!e.elements.length) {
this.editor.setAriaActiveDescendant(null);
this._lastSuggestionLabel = null;
// TODO@Alex: Chromium bug
// this.editor.setAriaActiveDescendant(null);
return;
}
const item = e.elements[0];
// TODO@Alex: the list is not done rendering...
setTimeout(() => {
this.editor.setAriaActiveDescendant(this.list.getElementId(e.indexes[0]));
}, 100);
if (item.suggestion.label !== this._lastSuggestionLabel) {
this._lastSuggestionLabel = item.suggestion.label;
alert(nls.localize('ariaCurrentSuggestion',"{0}, suggestion", this._lastSuggestionLabel));
}
// TODO@Alex: Chromium bug
// // TODO@Alex: the list is not done rendering...
// setTimeout(() => {
// this.editor.setAriaActiveDescendant(this.list.getElementId(e.indexes[0]));
// }, 100);
if (item === this.focusedItem) {
return;