Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-16 05:11:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Do not include line number value in exception message

Browse Source
This commit is contained in:
Alex Dima
2018-02-15 13:01:19 +01:00
parent 5d0366e78e
commit c869fef06c
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/editor/browser/view/viewLayer.ts
+1 -1
View File
@@ -80,7 +80,7 @@ export class RenderedLinesCollection<T extends ILine> {
public getLine(lineNumber: number): T {
let lineIndex = lineNumber - this._rendLineNumberStart;
if (lineIndex < 0 || lineIndex >= this._lines.length) {
throw new Error('Illegal value for lineNumber: ' + lineNumber);
throw new Error('Illegal value for lineNumber');
}
return this._lines[lineIndex];
}
src/vs/editor/common/model/textModel.ts
+8 -8
View File
@@ -773,7 +773,7 @@ export class TextModel extends Disposable implements model.ITextModel {
public getLineContent(lineNumber: number): string {
this._assertNotDisposed();
if (lineNumber < 1 || lineNumber > this.getLineCount()) {
throw new Error('Illegal value ' + lineNumber + ' for `lineNumber`');
throw new Error('Illegal value for lineNumber');
}
return this._buffer.getLineContent(lineNumber);
@@ -797,7 +797,7 @@ export class TextModel extends Disposable implements model.ITextModel {
public getLineMaxColumn(lineNumber: number): number {
this._assertNotDisposed();
if (lineNumber < 1 || lineNumber > this.getLineCount()) {
throw new Error('Illegal value ' + lineNumber + ' for `lineNumber`');
throw new Error('Illegal value for lineNumber');
}
return this._buffer.getLineLength(lineNumber) + 1;
}
@@ -805,7 +805,7 @@ export class TextModel extends Disposable implements model.ITextModel {
public getLineFirstNonWhitespaceColumn(lineNumber: number): number {
this._assertNotDisposed();
if (lineNumber < 1 || lineNumber > this.getLineCount()) {
throw new Error('Illegal value ' + lineNumber + ' for `lineNumber`');
throw new Error('Illegal value for lineNumber');
}
return this._buffer.getLineFirstNonWhitespaceColumn(lineNumber);
}
@@ -813,7 +813,7 @@ export class TextModel extends Disposable implements model.ITextModel {
public getLineLastNonWhitespaceColumn(lineNumber: number): number {
this._assertNotDisposed();
if (lineNumber < 1 || lineNumber > this.getLineCount()) {
throw new Error('Illegal value ' + lineNumber + ' for `lineNumber`');
throw new Error('Illegal value for lineNumber');
}
return this._buffer.getLineLastNonWhitespaceColumn(lineNumber);
}
@@ -1586,7 +1586,7 @@ export class TextModel extends Disposable implements model.ITextModel {
public forceTokenization(lineNumber: number): void {
if (lineNumber < 1 || lineNumber > this.getLineCount()) {
throw new Error('Illegal value ' + lineNumber + ' for `lineNumber`');
throw new Error('Illegal value for lineNumber');
}
const eventBuilder = new ModelTokensChangedEventBuilder();
@@ -1611,7 +1611,7 @@ export class TextModel extends Disposable implements model.ITextModel {
public getLineTokens(lineNumber: number): LineTokens {
if (lineNumber < 1 || lineNumber > this.getLineCount()) {
throw new Error('Illegal value ' + lineNumber + ' for `lineNumber`');
throw new Error('Illegal value for lineNumber');
}
return this._getLineTokens(lineNumber);
@@ -2163,10 +2163,10 @@ export class TextModel extends Disposable implements model.ITextModel {
const lineCount = this.getLineCount();
if (startLineNumber < 1 || startLineNumber > lineCount) {
throw new Error('Illegal value ' + startLineNumber + ' for `startLineNumber`');
throw new Error('Illegal value for startLineNumber');
}
if (endLineNumber < 1 || endLineNumber > lineCount) {
throw new Error('Illegal value ' + endLineNumber + ' for `endLineNumber`');
throw new Error('Illegal value for endLineNumber');
}
const foldingRules = LanguageConfigurationRegistry.getFoldingRules(this._languageIdentifier.id);