Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-15 07:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

clean up should prompt event. (#241520)

Browse Source
This commit is contained in:
Peng Lyu
2025-02-21 12:52:40 -08:00
committed by GitHub
parent 83f42a7a58
commit ca669a6865
1 changed files with 0 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
View File

@@ -45,7 +45,6 @@ import { EnablementState } from '../../../services/extensionManagement/common/ex
import { IWorkingCopyBackupService } from '../../../services/workingCopy/common/workingCopyBackup.js';
import { streamToBuffer } from '../../../../base/common/buffer.js';
import { ILogService } from '../../../../platform/log/common/log.js';
import { INotebookEditorWorkerService } from '../common/services/notebookWorkerService.js';
import { IPreferencesService } from '../../../services/preferences/common/preferences.js';
import { IActionViewItemOptions } from '../../../../base/browser/ui/actionbar/actionViewItems.js';
import { StopWatch } from '../../../../base/common/stopwatch.js';
@@ -96,7 +95,6 @@ export class NotebookEditor extends EditorPane implements INotebookEditorPane, I
@IExtensionsWorkbenchService private readonly _extensionsWorkbenchService: IExtensionsWorkbenchService,
@IWorkingCopyBackupService private readonly _workingCopyBackupService: IWorkingCopyBackupService,
@ILogService private readonly logService: ILogService,
@INotebookEditorWorkerService private readonly _notebookEditorWorkerService: INotebookEditorWorkerService,
@IPreferencesService private readonly _preferencesService: IPreferencesService
) {
super(NotebookEditor.ID, group, telemetryService, themeService, storageService);
@@ -334,7 +332,6 @@ export class NotebookEditor extends EditorPane implements INotebookEditorPane, I
}
this._handlePerfMark(perf, input, model.notebook);
this._handlePromptRecommendations(model.notebook);
} catch (e) {
this.logService.warn('NotebookEditorWidget#setInput failed', e);
if (isEditorOpenError(e)) {
@@ -506,24 +503,6 @@ export class NotebookEditor extends EditorPane implements INotebookEditorPane, I
});
}
private _handlePromptRecommendations(model: NotebookTextModel) {
this._notebookEditorWorkerService.canPromptRecommendation(model.uri).then(shouldPrompt => {
type WorkbenchNotebookShouldPromptRecommendationClassification = {
owner: 'rebornix';
comment: 'The notebook file metrics. Used to get a better understanding of if we should prompt for notebook extension recommendations';
shouldPrompt: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Should we prompt for notebook extension recommendations' };
};
type WorkbenchNotebookShouldPromptRecommendationEvent = {
shouldPrompt: boolean;
};
this.telemetryService.publicLog2<WorkbenchNotebookShouldPromptRecommendationEvent, WorkbenchNotebookShouldPromptRecommendationClassification>('notebook/shouldPromptRecommendation', {
shouldPrompt: shouldPrompt
});
});
}
override clearInput(): void {
this._inputListener.clear();