Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-17 23:35:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

agent host cleanups

Browse Source 
useFakedTimers, delete empty arch file, fix category
from copilot reviewing sessions skill
This commit is contained in:
Rob Lourens
2026-03-31 20:26:05 -07:00
parent eac55d867e
commit cab4755839
3 changed files with 30 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

0
src/vs/sessions/contrib/remoteAgentHost/ARCHITECTURE.md
View File

4
src/vs/sessions/contrib/remoteAgentHost/browser/remoteAgentHostActions.ts
View File

@@ -10,14 +10,14 @@ import { ContextKeyExpr } from '../../../../platform/contextkey/common/contextke
import { ServicesAccessor } from '../../../../platform/instantiation/common/instantiation.js';
import { INotificationService } from '../../../../platform/notification/common/notification.js';
import { IQuickInputService } from '../../../../platform/quickinput/common/quickInput.js';
import { CHAT_CATEGORY } from '../../../../workbench/contrib/chat/browser/actions/chatActions.js';
import { SessionsCategories } from '../../../common/categories.js';
registerAction2(class extends Action2 {
constructor() {
super({
id: 'sessions.remoteAgentHost.add',
title: localize2('addRemoteAgentHost', "Add Remote Agent Host..."),
category: CHAT_CATEGORY,
category: SessionsCategories.Sessions,
f1: true,
precondition: ContextKeyExpr.equals(`config.${RemoteAgentHostsEnabledSettingId}`, true),
});

54
src/vs/sessions/contrib/remoteAgentHost/test/browser/remoteAgentHostSessionsProvider.test.ts
View File

@@ -4,10 +4,12 @@
*--------------------------------------------------------------------------------------------*/
import assert from 'assert';
import { timeout } from '../../../../../base/common/async.js';
import { Emitter } from '../../../../../base/common/event.js';
import { DisposableStore, toDisposable } from '../../../../../base/common/lifecycle.js';
import { URI } from '../../../../../base/common/uri.js';
import { mock } from '../../../../../base/test/common/mock.js';
import { runWithFakedTimers } from '../../../../../base/test/common/timeTravelScheduler.js';
import { ensureNoDisposablesAreLeakedInTestSuite } from '../../../../../base/test/common/utils.js';
import { AgentSession, type IAgentConnection, type IAgentSessionMetadata } from '../../../../../platform/agentHost/common/agentService.js';
import type { ISessionAction } from '../../../../../platform/agentHost/common/state/protocol/action-origin.generated.js';
@@ -278,7 +280,7 @@ suite('RemoteAgentHostSessionsProvider', () => {
// ---- Session listing via refresh -------
test('getSessions populates from connection.listSessions', async () => {
test('getSessions populates from connection.listSessions', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
connection.addSession(createSession('list-1', { summary: 'First' }));
connection.addSession(createSession('list-2', { summary: 'Second' }));
@@ -287,12 +289,12 @@ suite('RemoteAgentHostSessionsProvider', () => {
disposables.add(provider.onDidChangeSessions((e: ISessionChangeEvent) => changes.push(e)));
provider.getSessions();
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
assert.ok(changes.length > 0);
const sessions = provider.getSessions();
assert.strictEqual(sessions.length, 2);
});
}));
// ---- Session lifecycle -------
@@ -406,11 +408,11 @@ suite('RemoteAgentHostSessionsProvider', () => {
assert.strictEqual(connection.dispatchedActions.length, 0);
});
test('renameSession increments clientSeq on successive calls', async () => {
test('renameSession increments clientSeq on successive calls', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
connection.addSession(createSession('seq-sess', { summary: 'Seq Test' }));
const provider = createProvider(disposables, connection);
provider.getSessions();
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
const sessions = provider.getSessions();
const target = sessions.find((s) => s.title.get() === 'Seq Test');
@@ -423,7 +425,7 @@ suite('RemoteAgentHostSessionsProvider', () => {
assert.strictEqual(connection.dispatchedActions.length, 2);
assert.strictEqual(connection.dispatchedActions[0].clientSeq, 0);
assert.strictEqual(connection.dispatchedActions[1].clientSeq, 1);
});
}));
test('server-echoed SessionTitleChanged updates cached title', () => {
const provider = createProvider(disposables, connection);
@@ -452,13 +454,13 @@ suite('RemoteAgentHostSessionsProvider', () => {
assert.strictEqual(changes[0].changed.length, 1);
});
test('renamed title survives session refresh from listSessions', async () => {
test('renamed title survives session refresh from listSessions', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
// Simulate server persisting the renamed title: after rename, listSessions
// returns the updated summary
connection.addSession(createSession('persist-sess', { summary: 'Original Title' }));
const provider = createProvider(disposables, connection);
provider.getSessions();
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
// Verify initial title
let sessions = provider.getSessions();
@@ -478,12 +480,12 @@ suite('RemoteAgentHostSessionsProvider', () => {
origin: undefined,
} as IActionEnvelope);
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
sessions = provider.getSessions();
target = sessions.find((s) => s.title.get() === 'Renamed Title');
assert.ok(target, 'Session should have renamed title after refresh');
});
}));
// ---- Send -------
@@ -497,12 +499,12 @@ suite('RemoteAgentHostSessionsProvider', () => {
// ---- Session data adapter -------
test('session adapter has correct workspace from working directory', async () => {
test('session adapter has correct workspace from working directory', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
connection.addSession(createSession('ws-sess', { summary: 'WS Test', workingDirectory: URI.parse('vscode-agent-host://localhost__4321/file/-/home/user/myrepo') }));
const provider = createProvider(disposables, connection);
provider.getSessions();
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
const sessions = provider.getSessions();
const wsSession = sessions.find((s) => s.title.get() === 'WS Test');
@@ -511,42 +513,42 @@ suite('RemoteAgentHostSessionsProvider', () => {
const workspace = wsSession!.workspace.get();
assert.ok(workspace, 'Workspace should be populated');
assert.strictEqual(workspace!.label, 'myrepo [Test Host]');
});
}));
test('session adapter without working directory has no workspace', async () => {
test('session adapter without working directory has no workspace', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
connection.addSession(createSession('no-ws-sess', { summary: 'No WS' }));
const provider = createProvider(disposables, connection);
provider.getSessions();
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
const sessions = provider.getSessions();
const session = sessions.find((s) => s.title.get() === 'No WS');
assert.ok(session, 'Session should exist');
assert.strictEqual(session!.workspace.get(), undefined);
});
}));
test('session adapter uses raw ID as fallback title', async () => {
test('session adapter uses raw ID as fallback title', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
connection.addSession(createSession('abcdef1234567890'));
const provider = createProvider(disposables, connection);
provider.getSessions();
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
const sessions = provider.getSessions();
const session = sessions[0];
assert.ok(session);
assert.strictEqual(session.title.get(), 'Session abcdef12');
});
}));
// ---- Refresh on turnComplete -------
test('turnComplete action triggers session refresh for matching provider', async () => {
test('turnComplete action triggers session refresh for matching provider', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
connection.addSession(createSession('turn-sess', { summary: 'Before', modifiedTime: 1000 }));
const provider = createProvider(disposables, connection);
provider.getSessions();
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
// Update on connection side
connection.addSession(createSession('turn-sess', { summary: 'After', modifiedTime: 5000 }));
@@ -563,12 +565,12 @@ suite('RemoteAgentHostSessionsProvider', () => {
origin: undefined,
} as IActionEnvelope);
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
assert.ok(changes.length > 0);
const updatedSession = provider.getSessions().find((s) => s.title.get() === 'After');
assert.ok(updatedSession, 'Session should have updated title');
});
}));
// ---- getSessionTypes -------
@@ -588,17 +590,17 @@ suite('RemoteAgentHostSessionsProvider', () => {
// ---- sessionType on adapters -------
test('session adapter uses logical session type, not resource scheme', async () => {
test('session adapter uses logical session type, not resource scheme', () => runWithFakedTimers<void>({ useFakeTimers: true }, async () => {
connection.addSession(createSession('type-sess', { summary: 'Type Test' }));
const provider = createProvider(disposables, connection);
provider.getSessions();
await new Promise(resolve => setTimeout(resolve, 50));
await timeout(0);
const sessions = provider.getSessions();
const session = sessions.find((s) => s.title.get() === 'Type Test');
assert.ok(session, 'Session should exist');
// sessionType should be the logical type (agent-host-copilot), not the resource scheme
assert.strictEqual(session!.sessionType, provider.sessionTypes[0].id);
});
}));
});