Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-17 09:23:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update editor configuration only after extensions are registered (#138302)

Browse Source 
* delay updating editor configurations when installe extensions are registered

* async function over Promise.then

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
This commit is contained in:
Sandeep Somavarapu
2021-12-02 09:23:33 +01:00
committed by GitHub
parent ff970e88e5
commit cbab504ea9
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/browser/parts/editor/editorConfiguration.ts
+13 -3
View File
@@ -11,6 +11,7 @@ import { IConfigurationRegistry, Extensions as ConfigurationExtensions, IConfigu
import { workbenchConfigurationNodeBase } from 'vs/workbench/common/configuration';
import { IEditorResolverService, RegisteredEditorInfo, RegisteredEditorPriority } from 'vs/workbench/services/editor/common/editorResolverService';
import { IJSONSchemaMap } from 'vs/base/common/jsonSchema';
import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions';
export class DynamicEditorGroupAutoLockConfiguration extends Disposable implements IWorkbenchContribution {
@@ -32,12 +33,21 @@ export class DynamicEditorGroupAutoLockConfiguration extends Disposable implemen
private configurationNode: IConfigurationNode | undefined;
constructor(
@IEditorResolverService private readonly editorResolverService: IEditorResolverService
@IEditorResolverService private readonly editorResolverService: IEditorResolverService,
@IExtensionService extensionService: IExtensionService,
) {
super();
this.updateConfiguration();
this.registerListeners();
// Editor configurations are getting updated very aggressively
// (atleast 20 times) while the extensions are getting registered.
// As such push out the dynamic editor auto lock configuration
// until after extensions registered.
(async ()=> {
await extensionService.whenInstalledExtensionsRegistered();
this.updateConfiguration();
this.registerListeners();
})();
}
private registerListeners(): void {