chat - show confirmation title in notification (#255813)

This commit is contained in:
Benjamin Pasero
2025-07-14 16:42:10 +02:00
committed by GitHub
parent 1af7f2d27a
commit cc41f037dc

View File

@@ -4,6 +4,7 @@
*--------------------------------------------------------------------------------------------*/
import * as dom from '../../../../../base/browser/dom.js';
import { renderStringAsPlaintext } from '../../../../../base/browser/markdownRenderer.js';
import { Button, ButtonWithDropdown, IButton, IButtonOptions } from '../../../../../base/browser/ui/button/button.js';
import { Action } from '../../../../../base/common/actions.js';
import { Emitter, Event } from '../../../../../base/common/event.js';
@@ -120,7 +121,7 @@ abstract class BaseChatConfirmationWidget extends Disposable {
private readonly notification = this._register(new MutableDisposable<DisposableStore>());
constructor(
title: string | IMarkdownString,
private title: string | IMarkdownString,
subtitle: string | IMarkdownString | undefined,
buttons: IChatConfirmationButton[],
@IInstantiationService protected readonly instantiationService: IInstantiationService,
@@ -200,9 +201,10 @@ abstract class BaseChatConfirmationWidget extends Disposable {
this._hostService.focus(targetWindow, { mode: FocusMode.Notify });
// Notify
const notification = await dom.triggerNotification(localize('notificationTitle', "Chat: Confirmation Required"),
const title = renderStringAsPlaintext(this.title);
const notification = await dom.triggerNotification(title ? localize('notificationTitle', "Chat: {0}", title) : localize('defaultTitle', "Chat: Confirmation Required"),
{
detail: localize('notificationDetail', "The current chat session requires your confirmation to proceed"),
detail: localize('notificationDetail', "The current chat session requires your confirmation to proceed."),
sticky: true
}
);