Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-17 22:00:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Enable used references by default (#196654)

Browse Source 
* Add sessionId, agent, and slash command to core telemetry

* Enable used references by default
This commit is contained in:
Rob Lourens
2023-10-25 16:39:23 -07:00
committed by GitHub
parent a35d42b8b5
commit cd8dfd268a
2 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/chat/browser/chatListRenderer.ts
+2 -2
View File
@@ -143,10 +143,10 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch
this._treePool = this._register(this.instantiationService.createInstance(TreePool, this._onDidChangeVisibility.event));
this._contentReferencesListPool = this._register(this.instantiationService.createInstance(ContentReferencesListPool, this._onDidChangeVisibility.event));
this._usedReferencesEnabled = configService.getValue('chat.experimental.usedReferences') ?? productService.quality !== 'stable';
this._usedReferencesEnabled = configService.getValue('chat.experimental.usedReferences') ?? true;
this._register(configService.onDidChangeConfiguration(e => {
if (e.affectsConfiguration('chat.experimental.usedReferences')) {
this._usedReferencesEnabled = configService.getValue('chat.experimental.usedReferences') ?? productService.quality !== 'stable';
this._usedReferencesEnabled = configService.getValue('chat.experimental.usedReferences') ?? true;
}
}));
}
src/vs/workbench/contrib/chat/common/chatServiceImpl.ts
+10 -2
View File
@@ -49,6 +49,8 @@ type ChatProviderInvokedEvent = {
totalTime: number | undefined;
result: 'success' | 'error' | 'errorWithOutput' | 'cancelled' | 'filtered';
requestType: 'string' | 'followup' | 'slashCommand';
chatSessionId: string;
agent: string;
slashCommand: string | undefined;
};
@@ -58,6 +60,8 @@ type ChatProviderInvokedClassification = {
totalTime: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; isMeasurement: true; comment: 'The total time it took to run the provider\'s `provideResponseWithProgress`.' };
result: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether invoking the ChatProvider resulted in an error.' };
requestType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The type of request that the user made.' };
chatSessionId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'A random ID for the session.' };
agent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The type of agent used.' };
slashCommand?: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The type of slashCommand used.' };
owner: 'roblourens';
comment: 'Provides insight into the performance of Chat providers.';
@@ -492,7 +496,9 @@ export class ChatService extends Disposable implements IChatService {
totalTime: stopWatch.elapsed(),
result: 'cancelled',
requestType,
slashCommand: usedSlashCommand?.command
agent: agentPart?.agent.id ?? '',
slashCommand: agentSlashCommandPart ? agentSlashCommandPart.command.name : usedSlashCommand?.command,
chatSessionId: model.sessionId
});
model.cancelRequest(request);
@@ -597,7 +603,9 @@ export class ChatService extends Disposable implements IChatService {
totalTime: rawResponse.timings?.totalElapsed,
result,
requestType,
slashCommand: usedSlashCommand?.command
agent: agentPart?.agent.id ?? '',
slashCommand: agentSlashCommandPart ? agentSlashCommandPart.command.name : usedSlashCommand?.command,
chatSessionId: model.sessionId
});
model.setResponse(request, rawResponse);
this.trace('sendRequest', `Provider returned response for session ${model.sessionId}`);