Merge pull request #216735 from microsoft/tyriar/216729

Fix terminal sticky scroll on HC themes

build/lib/stylelint/vscode-known-variables.json

@@ -714,6 +714,7 @@
 		"--vscode-terminalOverviewRuler-cursorForeground",
 		"--vscode-terminalOverviewRuler-findMatchForeground",
 		"--vscode-terminalStickyScroll-background",
+		"--vscode-terminalStickyScroll-border",
 		"--vscode-terminalStickyScrollHover-background",
 		"--vscode-testing-coverCountBadgeBackground",
 		"--vscode-testing-coverCountBadgeForeground",

src/vs/workbench/contrib/terminalContrib/stickyScroll/browser/media/stickyScroll.css

@@ -11,6 +11,7 @@
 	z-index: 32; /* Must be higher than .xterm-viewport and decorations */
 	background: var(--vscode-terminalStickyScroll-background, var(--vscode-terminal-background, var(--vscode-panel-background)));
 	box-shadow: var(--vscode-scrollbar-shadow) 0 3px 2px -2px;
+	border-bottom: 1px solid var(--vscode-terminalStickyScroll-border, transparent);
 }
 .part.sidebar .terminal-sticky-scroll,
 .part.auxiliarybar .terminal-sticky-scroll {

src/vs/workbench/contrib/terminalContrib/stickyScroll/browser/terminalStickyScrollColorRegistry.ts

@@ -3,7 +3,6 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { Color } from 'vs/base/common/color';
 import { localize } from 'vs/nls';
 import { registerColor } from 'vs/platform/theme/common/colorUtils';
 
@@ -17,6 +16,13 @@ export const terminalStickyScrollBackground = registerColor('terminalStickyScrol
 export const terminalStickyScrollHoverBackground = registerColor('terminalStickyScrollHover.background', {
 	dark: '#2A2D2E',
 	light: '#F0F0F0',
-	hcDark: null,
-	hcLight: Color.fromHex('#0F4A85').transparent(0.1)
+	hcDark: '#E48B39',
+	hcLight: '#0f4a85'
 }, localize('terminalStickyScrollHover.background', 'The background color of the sticky scroll overlay in the terminal when hovered.'));
+
+registerColor('terminalStickyScroll.border', {
+	dark: null,
+	light: null,
+	hcDark: '#6fc3df',
+	hcLight: '#0f4a85'
+}, localize('terminalStickyScroll.border', 'The border of the sticky scroll overlay in the terminal.'));