Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 20:26:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix task disposable leak (#283872)

Browse Source 
fixes #274750
This commit is contained in:
Megan Rogge
2025-12-16 13:05:08 -06:00
committed by GitHub
parent 53f4de24cb
commit cea4fe5e1c
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
View File

@@ -3015,7 +3015,12 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
return entries;
}
private async _showTwoLevelQuickPick(placeHolder: string, defaultEntry?: ITaskQuickPickEntry, type?: string, name?: string) {
return this._instantiationService.createInstance(TaskQuickPick).show(placeHolder, defaultEntry, type, name);
const taskQuickPick = this._instantiationService.createInstance(TaskQuickPick);
try {
return await taskQuickPick.show(placeHolder, defaultEntry, type, name);
} finally {
taskQuickPick.dispose();
}
}
private async _showQuickPick(tasks: Promise<Task[]> | Task[], placeHolder: string, defaultEntry?: ITaskQuickPickEntry, group: boolean = false, sort: boolean = false, selectedEntry?: ITaskQuickPickEntry, additionalEntries?: ITaskQuickPickEntry[], name?: string): Promise<ITaskQuickPickEntry | undefined | null> {