Merge pull request #45317 from Microsoft/isidorn/listServiceDropDisposed

listService: forget about disposed lists

src/vs/base/browser/ui/list/listPaging.ts

@@ -97,6 +97,10 @@ export class PagedList<T> implements IDisposable {
 		return this.list;
 	}
 
+	get onDidDispose(): Event<void> {
+		return this.list.onDidDispose;
+	}
+
 	get onFocusChange(): Event<IListEvent<T>> {
 		return mapEvent(this.list.onFocusChange, ({ elements, indexes }) => ({ elements: elements.map(e => this._model.get(e)), indexes }));
 	}
@@ -193,4 +197,4 @@ export class PagedList<T> implements IDisposable {
 	dispose(): void {
 		this.list.dispose();
 	}
-}
+}

src/vs/base/browser/ui/list/listWidget.ts

@@ -1059,7 +1059,7 @@ export class List<T> implements ISpliceable<T>, IDisposable {
 	}
 
 	isDOMFocused(): boolean {
-		return this.view && this.view.domNode === document.activeElement;
+		return this.view.domNode === document.activeElement;
 	}
 
 	getHTMLElement(): HTMLElement {

src/vs/base/parts/tree/browser/treeImpl.ts

@@ -131,7 +131,7 @@ export class Tree implements _.ITree {
 	}
 
 	public isDOMFocused(): boolean {
-		return this.view && this.view.isFocused();
+		return this.view.isFocused();
 	}
 
 	public domBlur(): void {

src/vs/platform/list/browser/listService.ts

@@ -73,7 +73,13 @@ export class ListService implements IListService {
 
 		const result = combinedDisposable([
 			widget.onDidFocus(() => this._lastFocusedWidget = widget),
-			toDisposable(() => this.lists.splice(this.lists.indexOf(registeredList), 1))
+			toDisposable(() => this.lists.splice(this.lists.indexOf(registeredList), 1)),
+			widget.onDidDispose(() => {
+				this.lists = this.lists.filter(l => l !== registeredList);
+				if (this._lastFocusedWidget === widget) {
+					this._lastFocusedWidget = undefined;
+				}
+			})
 		]);
 
 		return result;