Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 17:19:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Settings: Only add label target for checkbox (#57129)

Browse Source
This commit is contained in:
Christopher Leidigh
2018-08-24 01:32:16 -04:00
committed by GitHub
parent 803542327f
commit d200e76c49
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/parts/preferences/browser/settingsTree.ts
+7 -5
View File
@@ -678,11 +678,11 @@ export class SettingsRenderer implements ITreeRenderer {
// Also have to ignore embedded links - too buried to stop propagation
toDispose.push(DOM.addDisposableListener(descriptionElement, DOM.EventType.MOUSE_DOWN, (e) => {
const targetElement = <HTMLElement>e.toElement;
const targetId = descriptionElement.getAttribute('checkboxLabelTargetId');
const targetId = descriptionElement.getAttribute('checkbox-label-target-id');
// Make sure we are not a link and the target ID matches
// Toggle target checkbox
if (targetElement.tagName !== 'A' && targetId === template.checkbox.domNode.id) {
if (targetElement.tagName.toLowerCase() !== 'a' && targetId === template.checkbox.domNode.id) {
template.checkbox.checked = template.checkbox.checked ? false : true;
}
DOM.EventHelper.stop(e);
@@ -949,9 +949,11 @@ export class SettingsRenderer implements ITreeRenderer {
template.descriptionElement.innerText = element.description;
}
// Add checkbox target to description clickable and able to toggle checkbox
const checkbox_id = (element.displayCategory + '_' + element.displayLabel).replace(/ /g, '_') + '_Item';
template.descriptionElement.setAttribute('checkboxLabelTargetId', checkbox_id);
if (templateId === SETTINGS_BOOL_TEMPLATE_ID) {
// Add checkbox target to description clickable and able to toggle checkbox
const checkbox_id = (element.displayCategory + '_' + element.displayLabel).replace(/ /g, '_') + '_Item';
template.descriptionElement.setAttribute('checkbox-label-target-id', checkbox_id);
}
if (element.overriddenScopeList.length) {
let otherOverridesLabel = element.isConfigured ?