Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-08-04 20:36:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove cli.js argument when running as administrator on Windows (#296690)

Browse Source 
* fix: handle stray cli.js argument when running as administrator on Windows

* Handle version subdirectory.
This commit is contained in:
Dmitriy Vasyura
2026-02-23 08:19:42 -08:00
committed by GitHub
parent db8faee5ff
commit d311bc97b0
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/platform/environment/node/argvHelper.ts
+13 -1
View File
@@ -4,7 +4,8 @@
*--------------------------------------------------------------------------------------------*/
import assert from 'assert';
import { IProcessEnvironment } from '../../../base/common/platform.js';
import { dirname, resolve } from '../../../base/common/path.js';
import { IProcessEnvironment, isWindows } from '../../../base/common/platform.js';
import { localize } from '../../../nls.js';
import { NativeParsedArgs } from '../common/argv.js';
import { ErrorReporter, NATIVE_CLI_COMMANDS, OPTIONS, parseArgs } from './argv.js';
@@ -63,6 +64,17 @@ function stripAppPath(argv: string[]): string[] | undefined {
export function parseMainProcessArgv(processArgv: string[]): NativeParsedArgs {
let [, ...args] = processArgv;
// When code.exe is configured to 'Run as administrator' on Windows, the CLI launcher (code.cmd) sets ELECTRON_RUN_AS_NODE=1 and passes
// cli.js as the first argument. The elevated process does not inherit the environment variable so Electron starts as a GUI app with cli.js
// as a stray positional argument. Detect and strip it. The path may include a version subdirectory (e.g., 2ca3b2734b\resources\app\out\cli.js).
if (isWindows && args.length > 0) {
const resolvedArg = resolve(args[0]).toLowerCase();
const installDir = dirname(process.execPath).toLowerCase() + '\\';
if (resolvedArg.startsWith(installDir) && resolvedArg.endsWith('\\resources\\app\\out\\cli.js')) {
args.shift();
}
}
// If dev, remove the first non-option argument: it's the app location
if (process.env['VSCODE_DEV']) {
args = stripAppPath(args) || [];