Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-02 08:15:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #304973 from yogeshwaran-c/fix/svg-zoom-no-dimensions-v2

Browse Source 
fix: enable zoom for SVGs without explicit width/height dimensions
This commit is contained in:
Matt Bierner
2026-03-26 14:24:16 -07:00
committed by GitHub
parent 71e3258bcc 5281aa14f2
commit d5370dfd46
1 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
extensions/media-preview/media/imagePreview.js
View File

@@ -89,6 +89,9 @@
image.classList.remove('pixelated');
// @ts-ignore Non-standard CSS property
image.style.zoom = 'normal';
// Clear explicit dimensions so the image can scale-to-fit naturally
image.style.minWidth = '';
image.style.minHeight = '';
vscode.setState(undefined);
} else {
scale = clamp(newScale, MIN_SCALE, MAX_SCALE);
@@ -102,6 +105,17 @@
const dy = (window.scrollY + container.clientHeight / 2) / container.scrollHeight;
image.classList.remove('scale-to-fit');
// For images without intrinsic dimensions (e.g. SVGs with only
// a viewBox), set explicit pixel dimensions so that CSS zoom has
// something concrete to scale.
if (!image.naturalWidth || !image.naturalHeight) {
const baseWidth = image.clientWidth || container.clientWidth;
const baseHeight = image.clientHeight || container.clientHeight;
image.style.minWidth = baseWidth + 'px';
image.style.minHeight = baseHeight + 'px';
}
// @ts-ignore Non-standard CSS property
image.style.zoom = scale;
@@ -142,7 +156,14 @@
return;
}
scale = image.clientWidth / image.naturalWidth;
if (image.naturalWidth) {
scale = image.clientWidth / image.naturalWidth;
} else {
// For images without intrinsic dimensions (e.g. SVGs with
// only a viewBox), start at 1x since there is no meaningful
// natural size to compute a ratio from.
scale = 1;
}
updateScale(scale);
}