Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-02-15 07:28:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

debug: potential overlapping line fix (#242515)

Browse Source 
This fixes some errors in list view rendering that I think might have caused the issue.

Fixes #237332
This commit is contained in:
Connor Peet
2025-03-03 14:38:33 -08:00
committed by GitHub
parent f1f5327a74
commit dbfd94fde3
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/vs/base/browser/ui/list/listView.ts
View File

@@ -1243,7 +1243,11 @@ export class ListView<T> implements IListView<T> {
}));
selectionStore.add(addDisposableListener(doc, 'selectionchange', () => {
const selection = doc.getSelection();
if (!selection) {
// if the selection changed _after_ mouseup, it's from clearing the list or similar, so teardown
if (!selection || selection.isCollapsed) {
if (movementStore.isDisposed) {
selectionStore.dispose();
}
return;
}
@@ -1527,8 +1531,9 @@ export class ListView<T> implements IListView<T> {
protected getRenderRange(renderTop: number, renderHeight: number): IRange {
const range = this.getVisibleRange(renderTop, renderHeight);
if (this.currentSelectionBounds) {
range.start = Math.min(range.start, this.currentSelectionBounds.start);
range.end = Math.max(range.end, this.currentSelectionBounds.end + 1);
const max = this.rangeMap.count;
range.start = Math.min(range.start, this.currentSelectionBounds.start, max);
range.end = Math.min(Math.max(range.end, this.currentSelectionBounds.end + 1), max);
}
return range;