mirror of
https://github.com/microsoft/vscode.git
synced 2026-05-09 01:28:50 +01:00
Always show overview ruler decorations before command execution
Originally we hid the overview ruler decoration for command currently being input and executed. This ended up causing problems for commands that took a while to run and task decoration support as they would not get a mark in the overview ruler until the command finished. For simplicity let's just always show this, so there will basically always be a grey mark at the very bottom for the cursor line, but that is at least consistent and then we don't need to juggle different overview ruler options depending on the state of the command. Fixes #152663
This commit is contained in:
@@ -220,7 +220,9 @@ export class DecorationAddon extends Disposable implements ITerminalAddon {
|
||||
}
|
||||
const decoration = this._terminal.registerDecoration({
|
||||
marker: command.marker,
|
||||
overviewRulerOptions: beforeCommandExecution ? undefined : { color, position: command.exitCode ? 'right' : 'left' }
|
||||
overviewRulerOptions: beforeCommandExecution
|
||||
? { color, position: 'left' }
|
||||
: { color, position: command.exitCode ? 'right' : 'left' }
|
||||
});
|
||||
if (!decoration) {
|
||||
return undefined;
|
||||
|
||||
Reference in New Issue
Block a user