Finalize env.isAppPortalable API proposal (#297177)

extensions/github-authentication/package.json

@@ -19,8 +19,7 @@
   ],
   "enabledApiProposals": [
     "authIssuers",
-    "authProviderSpecific",
-    "envIsAppPortable"
+    "authProviderSpecific"
   ],
   "activationEvents": [],
   "capabilities": {

extensions/github-authentication/tsconfig.json

@@ -14,7 +14,6 @@
 		"src/**/*",
 		"../../src/vscode-dts/vscode.d.ts",
 		"../../src/vscode-dts/vscode.proposed.authIssuers.d.ts",
-		"../../src/vscode-dts/vscode.proposed.authProviderSpecific.d.ts",
-		"../../src/vscode-dts/vscode.proposed.envIsAppPortable.d.ts"
+		"../../src/vscode-dts/vscode.proposed.authProviderSpecific.d.ts"
 	]
 }

extensions/microsoft-authentication/package.json

@@ -16,8 +16,7 @@
   "enabledApiProposals": [
     "nativeWindowHandle",
     "authIssuers",
-    "authenticationChallenges",
-    "envIsAppPortable"
+    "authenticationChallenges"
   ],
   "capabilities": {
     "virtualWorkspaces": true,

extensions/microsoft-authentication/tsconfig.json

@@ -12,7 +12,6 @@
 		"../../src/vscode-dts/vscode.d.ts",
 		"../../src/vscode-dts/vscode.proposed.nativeWindowHandle.d.ts",
 		"../../src/vscode-dts/vscode.proposed.authIssuers.d.ts",
-		"../../src/vscode-dts/vscode.proposed.authenticationChallenges.d.ts",
-		"../../src/vscode-dts/vscode.proposed.envIsAppPortable.d.ts"
+		"../../src/vscode-dts/vscode.proposed.authenticationChallenges.d.ts"
 	]
 }

extensions/vscode-api-tests/package.json

@@ -18,7 +18,6 @@
     "documentFiltersExclusive",
     "editorInsets",
     "embeddings",
-    "envIsAppPortable",
     "envIsConnectionMetered",
     "extensionRuntime",
     "extensionsAny",

src/vs/platform/extensions/common/extensionsApiProposals.ts

@@ -234,9 +234,6 @@ const _allApiProposals = {
 	embeddings: {
 		proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.embeddings.d.ts',
 	},
-	envIsAppPortable: {
-		proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.envIsAppPortable.d.ts',
-	},
 	envIsConnectionMetered: {
 		proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.envIsConnectionMetered.d.ts',
 	},

src/vs/workbench/api/common/extHost.api.impl.ts

@@ -402,10 +402,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
 				checkProposedApiEnabled(extension, 'devDeviceId');
 				return initData.telemetryInfo.devDeviceId ?? initData.telemetryInfo.machineId;
 			},
-			get isAppPortable() {
-				checkProposedApiEnabled(extension, 'envIsAppPortable');
-				return initData.environment.isPortable ?? false;
-			},
+			get isAppPortable() { return initData.environment.isPortable ?? false; },
 			get sessionId() { return initData.telemetryInfo.sessionId; },
 			get language() { return initData.environment.appLanguage; },
 			get appName() { return initData.environment.appName; },

src/vscode-dts/vscode.d.ts

@@ -10791,6 +10791,16 @@ declare module 'vscode' {
 		 */
 		export const isNewAppInstall: boolean;
 
+		/**
+		 * Indicates whether the application is running in portable mode.
+		 *
+		 * Portable mode is enabled when the application is run from a folder that contains
+		 * a `data` directory, allowing for self-contained installations.
+		 *
+		 * Learn more about [Portable Mode](https://code.visualstudio.com/docs/editor/portable).
+		 */
+		export const isAppPortable: boolean;
+
 		/**
 		 * Indicates whether the users has telemetry enabled.
 		 * Can be observed to determine if the extension should send telemetry.

src/vscode-dts/vscode.proposed.envIsAppPortable.d.ts

@@ -1,20 +0,0 @@
-/*---------------------------------------------------------------------------------------------
- *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
- *--------------------------------------------------------------------------------------------*/
-
-declare module 'vscode' {
-
-	export namespace env {
-
-		/**
-		 * Indicates whether the application is running in portable mode.
-		 *
-		 * Portable mode is enabled when the application is run from a folder that contains
-		 * a `data` directory, allowing for self-contained installations.
-		 *
-		 * Learn more about [Portable Mode](https://code.visualstudio.com/docs/editor/portable).
-		 */
-		export const isAppPortable: boolean;
-	}
-}