Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-17 01:13:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use ILocalizedString correctly

Browse Source
This commit is contained in:
gjsjohnmurray
2024-03-06 16:21:58 +00:00
parent 6536c8b045
commit ee36c8c2df
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/platform/log/common/log.ts
+6 -6
View File
@@ -749,12 +749,12 @@ export function LogLevelToString(logLevel: LogLevel): string {
export function LogLevelToLocalizedString(logLevel: LogLevel): ILocalizedString {
switch (logLevel) {
case LogLevel.Trace: return { original: 'trace', value: nls.localize('trace', "Trace") };
case LogLevel.Debug: return { original: 'debug', value: nls.localize('debug', "Debug") };
case LogLevel.Info: return { original: 'info', value: nls.localize('info', "Info") };
case LogLevel.Warning: return { original: 'warn', value: nls.localize('warn', "Warning") };
case LogLevel.Error: return { original: 'error', value: nls.localize('error', "Error") };
case LogLevel.Off: return { original: 'off', value: nls.localize('off', "Off") };
case LogLevel.Trace: return { original: 'Trace', value: nls.localize('trace', "Trace") };
case LogLevel.Debug: return { original: 'Debug', value: nls.localize('debug', "Debug") };
case LogLevel.Info: return { original: 'Info', value: nls.localize('info', "Info") };
case LogLevel.Warning: return { original: 'Warning', value: nls.localize('warn', "Warning") };
case LogLevel.Error: return { original: 'Error', value: nls.localize('error', "Error") };
case LogLevel.Off: return { original: 'Off', value: nls.localize('off', "Off") };
}
}
src/vs/workbench/contrib/output/browser/output.contribution.ts
+3 -4
View File
@@ -30,7 +30,7 @@ import { Categories } from 'vs/platform/action/common/actionCommonCategories';
import { Disposable, dispose, IDisposable, toDisposable } from 'vs/base/common/lifecycle';
import { IFilesConfigurationService } from 'vs/workbench/services/filesConfiguration/common/filesConfigurationService';
import { AccessibilitySignal, IAccessibilitySignalService } from 'vs/platform/accessibilitySignal/browser/accessibilitySignalService';
import { ILoggerService, LogLevel, LogLevelToLocalizedString } from 'vs/platform/log/common/log';
import { ILoggerService, LogLevel, LogLevelToLocalizedString, LogLevelToString } from 'vs/platform/log/common/log';
import { IDefaultLogLevelsService } from 'vs/workbench/contrib/logs/common/defaultLogLevels';
// Register Service
@@ -351,13 +351,12 @@ class OutputContribution extends Disposable implements IWorkbenchContribution {
let order = 0;
const registerLogLevel = (logLevel: LogLevel) => {
const { original, value } = LogLevelToLocalizedString(logLevel);
this._register(registerAction2(class extends Action2 {
constructor() {
super({
id: `workbench.action.output.activeOutputLogLevel.${logLevel}`,
title: value,
toggled: CONTEXT_ACTIVE_OUTPUT_LEVEL.isEqualTo(original),
title: LogLevelToLocalizedString(logLevel).value,
toggled: CONTEXT_ACTIVE_OUTPUT_LEVEL.isEqualTo(LogLevelToString(logLevel)),
menu: {
id: logLevelMenu,
order: order++,