Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-08-12 08:44:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Aggressive caching with Open Current File as Release Notes (#205846)

Browse Source 
Fixes #205675
This commit is contained in:
Alex Ross
2024-02-21 11:45:40 +01:00
committed by GitHub
parent bf48061fc5
commit ef64ed413f
2 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/update/browser/releaseNotesEditor.ts
+13 -5
View File
@@ -45,7 +45,6 @@ export class ReleaseNotesManager {
private readonly disposables = new DisposableStore();
public constructor(
private readonly _useCurrentFile: boolean,
@IEnvironmentService private readonly _environmentService: IEnvironmentService,
@IKeybindingService private readonly _keybindingService: IKeybindingService,
@ILanguageService private readonly _languageService: ILanguageService,
@@ -81,8 +80,8 @@ export class ReleaseNotesManager {
}
}
public async show(version: string): Promise<boolean> {
const releaseNoteText = await this.loadReleaseNotes(version);
public async show(version: string, useCurrentFile: boolean): Promise<boolean> {
const releaseNoteText = await this.loadReleaseNotes(version, useCurrentFile);
this._lastText = releaseNoteText;
const html = await this.renderBody(releaseNoteText);
const title = nls.localize('releaseNotesInputName', "Release Notes: {0}", version);
@@ -137,7 +136,7 @@ export class ReleaseNotesManager {
return true;
}
private async loadReleaseNotes(version: string): Promise<string> {
private async loadReleaseNotes(version: string, useCurrentFile: boolean): Promise<string> {
const match = /^(\d+\.\d+)\./.exec(version);
if (!match) {
throw new Error('not found');
@@ -199,7 +198,12 @@ export class ReleaseNotesManager {
const fetchReleaseNotes = async () => {
let text;
try {
text = this._useCurrentFile ? this._codeEditorService.getActiveCodeEditor()?.getModel()?.getValue() : await asTextOrError(await this._requestService.request({ url }, CancellationToken.None));
if (useCurrentFile) {
const file = this._codeEditorService.getActiveCodeEditor()?.getModel()?.getValue();
text = file ? file.substring(file.indexOf('#')) : undefined;
} else {
text = await asTextOrError(await this._requestService.request({ url }, CancellationToken.None));
}
} catch {
throw new Error('Failed to fetch release notes');
}
@@ -211,6 +215,10 @@ export class ReleaseNotesManager {
return patchKeybindings(text);
};
// Don't cache the current file
if (useCurrentFile) {
return fetchReleaseNotes();
}
if (!this._releaseNotesCache.has(version)) {
this._releaseNotesCache.set(version, (async () => {
try {
src/vs/workbench/contrib/update/browser/update.ts
+2 -2
View File
@@ -40,10 +40,10 @@ let releaseNotesManager: ReleaseNotesManager | undefined = undefined;
export function showReleaseNotesInEditor(instantiationService: IInstantiationService, version: string, useCurrentFile: boolean) {
if (!releaseNotesManager) {
releaseNotesManager = instantiationService.createInstance(ReleaseNotesManager, useCurrentFile);
releaseNotesManager = instantiationService.createInstance(ReleaseNotesManager);
}
return releaseNotesManager.show(version);
return releaseNotesManager.show(version, useCurrentFile);
}
async function openLatestReleaseNotesInBrowser(accessor: ServicesAccessor) {